You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm not even sure if this can be done, I'm just throwing this out there.
First idea that comes to mind is a dry-run of sorts, and warn about any downgrade, with maybe a acontinue yes/no modal, and I would hapily skip that node until it is updated, or at all.
As it is at this rn, I can either check out the requirements of the repo and compare with current installation (very tedious) or just install it, see if/what it breaks, and take it from there.
Another idea is the ability to roll-back a faulty install. I've noticed that a backup of current nodes list is created before any node install, but I have no idea how to use that. furthermore, if the node dependencies prevents comfyui from running entirely, I'm pretty sure that json can't be used in any way.
I know that the same thing can be said about upgrading packages, but from my experience this case might break some other custom nodes, but never the host, which is much better from my perspective.
I have also considered the yes/no modal option, but I am still deliberating on it. The issue is that I need to find a solution for cases where multiple packages are being installed, as this could lead to the modal appearing very frequently during a single installation process.
At present, the backup/restore functionality is limited as it only operates at the version level of custom nodes. I am considering implementing it at the pip package level.
However, I am somewhat hesitant about this approach because it would require very extensive installation changes.
I'm thinking of applying this in a way that allows it to be selectively applied during the restore dialog.
Is there any functionality that could be declared via config or something so that some packages would not be downgraded? (for example, to put their pinned version at the end of the update/reinstall actions)
I am rewriting my project here so that it would start using Manager - since you easily accept PRs (for which I thank you very much!) - it is easier to fix everything in your repository than to repeat this functionality.
And I ran into a situation where one node is dependent on the inference-gpu package - and that package strictly specifies the old version of FastAPI.
As a result, after the update, the entire project does not work at all, because it is not compatible with the old version of FastAPI.
If it were possible to somehow define an action at the end of any update or installation, so that at the end the required python package would always be of the required version - it would be good.
I just haven't figured out yet how to do this correctly
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
I'm not even sure if this can be done, I'm just throwing this out there.
First idea that comes to mind is a dry-run of sorts, and warn about any downgrade, with maybe a acontinue yes/no modal, and I would hapily skip that node until it is updated, or at all.
As it is at this rn, I can either check out the requirements of the repo and compare with current installation (very tedious) or just install it, see if/what it breaks, and take it from there.
Another idea is the ability to roll-back a faulty install. I've noticed that a backup of current nodes list is created before any node install, but I have no idea how to use that. furthermore, if the node dependencies prevents comfyui from running entirely, I'm pretty sure that json can't be used in any way.
I know that the same thing can be said about upgrading packages, but from my experience this case might break some other custom nodes, but never the host, which is much better from my perspective.
Beta Was this translation helpful? Give feedback.
All reactions