-
Notifications
You must be signed in to change notification settings - Fork 673
Expand file tree
/
Copy pathDomWidgets.test.ts
More file actions
297 lines (234 loc) · 9.35 KB
/
Copy pathDomWidgets.test.ts
File metadata and controls
297 lines (234 loc) · 9.35 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
import { createTestingPinia } from '@pinia/testing'
import { fromPartial } from '@total-typescript/shoehorn'
import { render } from '@testing-library/vue'
import { setActivePinia } from 'pinia'
import { beforeEach, describe, expect, it, vi } from 'vitest'
import DomWidgets from '@/components/graph/DomWidgets.vue'
import { Rectangle } from '@/lib/litegraph/src/infrastructure/Rectangle'
import { LGraph, LGraphNode } from '@/lib/litegraph/src/litegraph'
import type { LGraphCanvas } from '@/lib/litegraph/src/LGraphCanvas'
import { useCanvasStore } from '@/renderer/core/canvas/canvasStore'
import type { BaseDOMWidget } from '@/scripts/domWidget'
import { useDomWidgetStore } from '@/stores/domWidgetStore'
import { toNodeId } from '@/types/nodeId'
type TestWidget = BaseDOMWidget<object | string>
function createNode(
graph: LGraph,
id: number,
title: string,
pos: [number, number]
) {
const node = new LGraphNode(title)
node.id = toNodeId(id)
node.pos = [...pos]
node.size = [240, 120]
graph.add(node)
return node
}
function createWidget(id: string, node: LGraphNode, y = 12): TestWidget {
return fromPartial<TestWidget>({
id,
node,
name: 'test_widget',
type: 'custom',
value: '',
options: {},
y,
width: 120,
computedHeight: 40,
margin: 10,
isVisible: () => true
})
}
function createCanvas(graph: LGraph): LGraphCanvas {
return fromPartial<LGraphCanvas>({
graph,
low_quality: false,
read_only: false,
isNodeVisible: vi.fn(() => true),
ds: { offset: [0, 0], scale: 1 },
selected_nodes: {}
})
}
function drawFrame(canvas: LGraphCanvas) {
canvas.onDrawForeground?.({} as CanvasRenderingContext2D, new Rectangle())
}
describe('DomWidgets positioning', () => {
beforeEach(() => {
setActivePinia(createTestingPinia({ stubActions: false }))
})
it('positions an active visible widget relative to its owning node', () => {
const canvasStore = useCanvasStore()
const domWidgetStore = useDomWidgetStore()
const graph = new LGraph()
const node = createNode(graph, 1, 'host', [100, 200])
const widget = createWidget('widget-pos', node, 14)
domWidgetStore.registerWidget(widget)
const canvas = createCanvas(graph)
canvasStore.canvas = canvas
render(DomWidgets, {
global: { stubs: { DomWidget: true } }
})
drawFrame(canvas)
const widgetState = domWidgetStore.widgetStates.get(widget.id)
if (!widgetState) throw new Error('Widget state not registered')
expect(widgetState.visible).toBe(true)
expect(widgetState.pos).toEqual([110, 224])
})
it('hides a widget whose owning node is in a different graph', () => {
const canvasStore = useCanvasStore()
const domWidgetStore = useDomWidgetStore()
const currentGraph = new LGraph()
const otherGraph = new LGraph()
const node = createNode(otherGraph, 1, 'host', [100, 200])
const widget = createWidget('widget-other-graph', node, 14)
domWidgetStore.registerWidget(widget)
const canvas = createCanvas(currentGraph)
canvasStore.canvas = canvas
render(DomWidgets, {
global: { stubs: { DomWidget: true } }
})
drawFrame(canvas)
const widgetState = domWidgetStore.widgetStates.get(widget.id)
if (!widgetState) throw new Error('Widget state not registered')
expect(widgetState.visible).toBe(false)
})
it('hides an inactive widget', () => {
const canvasStore = useCanvasStore()
const domWidgetStore = useDomWidgetStore()
const graph = new LGraph()
const node = createNode(graph, 1, 'host', [0, 0])
const widget = createWidget('widget-inactive', node, 10)
domWidgetStore.registerWidget(widget)
domWidgetStore.deactivateWidget(widget.id)
const widgetState = domWidgetStore.widgetStates.get(widget.id)
if (!widgetState) throw new Error('Widget state not registered')
widgetState.visible = true
const canvas = createCanvas(graph)
canvasStore.canvas = canvas
render(DomWidgets, {
global: { stubs: { DomWidget: true } }
})
drawFrame(canvas)
expect(widgetState.visible).toBe(false)
})
it('forces pos reassignment on viewport pan even when canvas-space pos is unchanged', () => {
const canvasStore = useCanvasStore()
const domWidgetStore = useDomWidgetStore()
const graph = new LGraph()
const node = createNode(graph, 1, 'node', [100, 200])
const widget = createWidget('viewport-widget', node, 12)
domWidgetStore.registerWidget(widget)
const canvas = createCanvas(graph)
canvasStore.canvas = canvas
render(DomWidgets, {
global: { stubs: { DomWidget: true } }
})
drawFrame(canvas)
const widgetState = domWidgetStore.widgetStates.get(widget.id)
if (!widgetState) throw new Error('Widget state not registered')
const posAfterFirstFrame = widgetState.pos
expect(posAfterFirstFrame).toEqual([110, 222])
// Canvas pan: ds.offset is non-reactive, so the downstream watcher only
// fires if widgetState.pos is reassigned (a new array identity).
canvas.ds.offset[0] = 50
canvas.ds.offset[1] = 60
drawFrame(canvas)
expect(widgetState.pos).not.toBe(posAfterFirstFrame)
})
it('skips pos reassignment when viewport and canvas-space pos are both stable', () => {
const canvasStore = useCanvasStore()
const domWidgetStore = useDomWidgetStore()
const graph = new LGraph()
const node = createNode(graph, 1, 'node', [100, 200])
const widget = createWidget('idle-widget', node, 12)
domWidgetStore.registerWidget(widget)
const canvas = createCanvas(graph)
canvasStore.canvas = canvas
render(DomWidgets, {
global: { stubs: { DomWidget: true } }
})
drawFrame(canvas)
const widgetState = domWidgetStore.widgetStates.get(widget.id)
if (!widgetState) throw new Error('Widget state not registered')
const posAfterFirstFrame = widgetState.pos
// No pan, no node movement — pos array identity must be preserved
// (this is the perf optimization being protected).
drawFrame(canvas)
expect(widgetState.pos).toBe(posAfterFirstFrame)
})
it('mirrors widget.computedDisabled into widgetState each frame', () => {
const canvasStore = useCanvasStore()
const domWidgetStore = useDomWidgetStore()
const graph = new LGraph()
const node = createNode(graph, 1, 'node', [100, 200])
const widget = createWidget('disabled-widget', node, 12)
Object.assign(widget, { computedDisabled: false })
domWidgetStore.registerWidget(widget)
const canvas = createCanvas(graph)
canvasStore.canvas = canvas
render(DomWidgets, {
global: { stubs: { DomWidget: true } }
})
drawFrame(canvas)
const widgetState = domWidgetStore.widgetStates.get(widget.id)
if (!widgetState) throw new Error('Widget state not registered')
expect(widgetState.computedDisabled).toBe(false)
// Simulate litegraph connecting an input -> widget.computedDisabled flips.
Object.assign(widget, { computedDisabled: true })
drawFrame(canvas)
expect(widgetState.computedDisabled).toBe(true)
})
it('forces pos reassignment for widgets when the selected node moves', () => {
const canvasStore = useCanvasStore()
const domWidgetStore = useDomWidgetStore()
const graph = new LGraph()
const movingNode = createNode(graph, 1, 'moving', [100, 100])
const otherNode = createNode(graph, 2, 'other', [400, 100])
const widget = createWidget('clipped-widget', otherNode, 12)
domWidgetStore.registerWidget(widget)
const canvas = createCanvas(graph)
// movingNode is the selected node — its renderArea drives clipping for
// widgets owned by other nodes.
canvas.selected_nodes = { 1: movingNode }
canvasStore.canvas = canvas
render(DomWidgets, {
global: { stubs: { DomWidget: true } }
})
drawFrame(canvas)
const widgetState = domWidgetStore.widgetStates.get(widget.id)
if (!widgetState) throw new Error('Widget state not registered')
const posAfterFirstFrame = widgetState.pos
// Drag the selected node — otherNode (and its widget) hasn't moved, but
// the widget's clip-path depends on movingNode.renderArea, so the
// downstream pos watcher must re-fire.
movingNode.pos[0] = 150
drawFrame(canvas)
expect(widgetState.pos).not.toBe(posAfterFirstFrame)
})
})
describe('DomWidgets reactive-write budget', () => {
beforeEach(() => {
setActivePinia(createTestingPinia({ stubActions: false }))
})
it('pos array identity is preserved across N idle frames (perf invariant)', () => {
const canvasStore = useCanvasStore()
const domWidgetStore = useDomWidgetStore()
const graph = new LGraph()
const node = createNode(graph, 1, 'node', [100, 200])
const widget = createWidget('perf-widget', node, 12)
domWidgetStore.registerWidget(widget)
const canvas = createCanvas(graph)
canvasStore.canvas = canvas
render(DomWidgets, { global: { stubs: { DomWidget: true } } })
// Warm-up: first frame writes initial pos.
drawFrame(canvas)
const widgetState = domWidgetStore.widgetStates.get(widget.id)
if (!widgetState) throw new Error('Widget state not registered')
const posAfterWarmup = widgetState.pos
// 20 idle frames: canvas stationary, no node movement, no pan.
// The pos array must not be reassigned (same reference = no reactive write).
for (let i = 0; i < 20; i++) drawFrame(canvas)
expect(widgetState.pos).toBe(posAfterWarmup)
})
})