Merge branch 'main' into feature/ecs-migration

Author: christian-byrne

.gitattributes

@@ -6,3 +6,4 @@ packages/registry-types/src/comfyRegistryTypes.ts linguist-generated=true
 packages/ingest-types/src/types.gen.ts linguist-generated=true
 packages/ingest-types/src/zod.gen.ts linguist-generated=true
 src/workbench/extensions/manager/types/generatedManagerTypes.ts linguist-generated=true
+browser_tests/fixtures/data/customNodeManifest.cloud.json linguist-generated=true

.github/actions/changes-filter/action.yaml

@@ -51,7 +51,7 @@ runs:
     - name: Filter typed changes
       if: ${{ github.event_name == 'pull_request' }}
       id: filter
-      uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
+      uses: dorny/paths-filter@ceb8a2b8f2d89434be7ff52d3de7ec3738c5cc9d # v4.0.3
       with:
         filters: |
           app_website:
@@ -75,7 +75,7 @@ runs:
     - name: Filter relevant changes
       if: ${{ github.event_name == 'pull_request' }}
       id: relevant
-      uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
+      uses: dorny/paths-filter@ceb8a2b8f2d89434be7ff52d3de7ec3738c5cc9d # v4.0.3
       with:
         predicate-quantifier: 'every'
         filters: |

.github/actions/setup-comfyui-server/action.yaml

@@ -9,6 +9,10 @@ inputs:
     description: 'Whether to launch the server after setup'
     required: false
     default: 'false'
+  comfyui_ref:
+    description: 'ComfyUI git ref to check out (tag/branch/SHA). Empty = default branch (master).'
+    required: false
+    default: ''
 runs:
   using: 'composite'
   steps:
@@ -19,6 +23,7 @@ runs:
       uses: actions/checkout@v7
       with:
         repository: 'comfyanonymous/ComfyUI'
+        ref: ${{ inputs.comfyui_ref }}
         path: 'ComfyUI'
 
     - name: Install ComfyUI_devtools from frontend repo

.github/actions/setup-frontend/action.yaml

@@ -5,6 +5,10 @@ inputs:
     description: 'Include the build step to build the frontend. Set to true for workflows that need a built frontend'
     required: false
     default: 'false'
+  node_cache:
+    description: "Share the lockfile-keyed pnpm store cache. Set to 'false' in jobs that execute unreviewed third-party code: setup-node's post step writes the store AFTER the job body, and the same key is restored by the publish workflows, which hold NPM_TOKEN, PYPI_TOKEN and id-token: write."
+    required: false
+    default: 'true'
 runs:
   using: 'composite'
   steps:
@@ -18,7 +22,7 @@ runs:
       uses: actions/setup-node@v6
       with:
         node-version-file: '.nvmrc'
-        cache: 'pnpm'
+        cache: ${{ inputs.node_cache == 'true' && 'pnpm' || '' }}
         cache-dependency-path: './pnpm-lock.yaml'
 
     - name: Install dependencies

.github/actions/setup-playwright/action.yaml

@@ -1,5 +1,10 @@
 name: Setup Playwright
 description: Cache and install Playwright browsers with dependencies
+inputs:
+  install_deps:
+    description: Install Playwright operating-system dependencies
+    required: false
+    default: 'true'
 runs:
   using: composite
   steps:
@@ -17,12 +22,33 @@ runs:
         path: '~/.cache/ms-playwright'
         key: ${{ runner.os }}-playwright-browsers-${{ steps.detect-version.outputs.playwright-version }}
 
-    - name: Install Playwright Browsers
-      if: steps.cache-playwright-browsers.outputs.cache-hit != 'true'
+    - name: Bound Playwright dependency downloads
+      if: inputs.install_deps == 'true'
       shell: bash
-      run: pnpm exec playwright install chromium --with-deps
+      run: |
+        set -euo pipefail
+        printf '%s\n' \
+          'Acquire::Retries "3";' \
+          'Acquire::http::Timeout "60";' \
+          'Acquire::https::Timeout "60";' \
+          | sudo tee /etc/apt/apt.conf.d/80-playwright-ci >/dev/null
 
-    - name: Install Playwright Browsers (operating system dependencies)
-      if: steps.cache-playwright-browsers.outputs.cache-hit == 'true'
+    - name: Install Playwright browser and dependencies
       shell: bash
-      run: pnpm exec playwright install-deps
+      env:
+        BROWSER_CACHE_HIT: ${{ steps.cache-playwright-browsers.outputs.cache-hit }}
+        INSTALL_DEPS: ${{ inputs.install_deps }}
+      run: |
+        set -euo pipefail
+        if [ "$INSTALL_DEPS" != true ]; then
+          playwright_args=(install chromium)
+        elif [ "$BROWSER_CACHE_HIT" = true ]; then
+          playwright_args=(install-deps chromium)
+        else
+          playwright_args=(install chromium --with-deps)
+        fi
+        for attempt in 1 2; do
+          pnpm exec playwright "${playwright_args[@]}" && exit 0
+          [ "$attempt" -lt 2 ] || exit 1
+          sleep 2
+        done