Commit 11011a6
fix(website): clear the real ESLint findings in apps/website (#15301)
*PR Created by the Glary-Bot Agent*
---
## Summary
Running the repo's full ESLint ruleset over `apps/website` reports 181
errors. 169 are auto-fixable Tailwind class ordering (handled in the
next PR); this PR clears the 12 that are not.
> Stacked on #15300. Base is `glary/website-strict-tsconfig`, so review
only the top commit.
## Changes
- **What**:
- `components/product/api/HeroSection.vue` — `stampAmt` and
`conveyorEject` were initialised to `0` and then unconditionally
reassigned by **both** branches of the following `if`/`else`, so the
initialiser never survived. Declared without an initialiser;
TypeScript's definite-assignment analysis covers both paths.
- `eslint.config.ts` — the other 10 findings are
`vue/no-unused-properties` false positives on the reka-ui wrappers under
`components/ui/`, which re-declare a component's props and forward them
wholesale via `useForwardPropsEmits` / `reactiveOmit` + `v-bind`. The
rule only tracks props referenced by name, so it cannot see the
forwarding. The rule is now off for the six wrapper directories.
- **Breaking**: none.
## Review Focus
**Why a config exception rather than deleting the props.** Deleting them
would remove each component's public API — `Sheet.vue` declares
`DialogRootProps` purely to forward them. That the codebase already
agrees is visible in the tree: **eight of these wrappers carry
file-local `/* eslint-disable vue/no-unused-properties -- props
forwarded via ... */` comments today**, in `accordion/` and `dialog/`.
The `sheet/` ones had simply been missed, which is why they showed up as
errors. This moves that existing, hand-maintained exception into config
so new wrappers cannot drift the same way. (The now-redundant inline
disables are removed by the autofix in the next PR.)
**Scope is deliberately narrow.** An earlier revision disabled the rule
for all of `components/ui/**`, which would have silently dropped the
check on the ten bespoke directories there. It is now limited to the six
directories that actually use forwarding helpers. Verified with `eslint
--print-config`:
| file | `vue/no-unused-properties` |
|---|---|
| `copyable-field/CopyableField.vue` | `[2]` — active |
| `scroll-carousel/ScrollCarousel.vue` | `[2]` — active |
| `badge/Badge.vue` | `[2]` — active |
| `toggle/Toggle.vue` | `[2]` — active |
| `sheet/Sheet.vue` | `[0]` — exempt |
| `dialog/Dialog.vue` | `[0]` — exempt |
## Verification
ESLint on `apps/website` drops from 181 errors to 169 — all remaining
are the auto-fixable Tailwind rules. `astro check` 0 errors · 422 unit
tests passing (1 pre-existing `minimaxMusic3` failure, also on `main`) ·
production build 595 pages.
`HeroSection` drives a `<canvas>` animation from those two variables, so
I checked it in a production build rather than trusting the
type-checker: sampling the full canvas across 6 frames gives 6 distinct
checksums, i.e. still animating. (An initial sample of only the top-left
300×300 showed no change — that region is the uniform `fillRect`
background, not a regression.)
Co-authored-by: Glary-Bot <glary-bot@users.noreply.github.com>1 parent 7f68e89 commit 11011a6
2 files changed
Lines changed: 22 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
109 | 109 | | |
110 | 110 | | |
111 | 111 | | |
112 | | - | |
113 | | - | |
| 112 | + | |
| 113 | + | |
114 | 114 | | |
115 | 115 | | |
116 | 116 | | |
| |||
224 | 224 | | |
225 | 225 | | |
226 | 226 | | |
227 | | - | |
| 227 | + | |
228 | 228 | | |
229 | 229 | | |
230 | 230 | | |
231 | 231 | | |
232 | 232 | | |
233 | | - | |
| 233 | + | |
234 | 234 | | |
235 | 235 | | |
236 | 236 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
488 | 488 | | |
489 | 489 | | |
490 | 490 | | |
| 491 | + | |
| 492 | + | |
| 493 | + | |
| 494 | + | |
| 495 | + | |
| 496 | + | |
| 497 | + | |
| 498 | + | |
| 499 | + | |
| 500 | + | |
| 501 | + | |
| 502 | + | |
| 503 | + | |
| 504 | + | |
| 505 | + | |
| 506 | + | |
| 507 | + | |
| 508 | + | |
491 | 509 | | |
492 | 510 | | |
493 | 511 | | |
| |||
0 commit comments