fix: keep Ctrl/Cmd shortcuts from falling through to the browser

The modal gate returned before event.preventDefault(), handing a combo the
app owns back to the browser whenever any dialog was open. Ctrl+S then
opened the browser's save-page dialog instead of saving.

Suppress the default for Ctrl/Cmd combos only. Bare keys still reach inputs
inside the dialog, which is what the gate was added to protect.

- Fixes FE-1188

Author: Connor Byrne

browser_tests/tests/defaultKeybindings.spec.ts

@@ -236,6 +236,28 @@ test.describe('Default Keybindings', { tag: '@keyboard' }, () => {
       await comfyPage.keyboard.press('Escape')
     })
 
+    test("'Ctrl+s' does not fall through to the browser while a dialog is open", async ({
+      comfyPage
+    }) => {
+      await comfyPage.keyboard.press('Control+s')
+      await expect(comfyPage.page.getByRole('dialog')).toBeVisible()
+
+      await comfyPage.page.evaluate(() => {
+        window.TestCommand = false
+        window.addEventListener('keydown', (event: KeyboardEvent) => {
+          if (event.key === 's') window.TestCommand = event.defaultPrevented
+        })
+      })
+
+      await comfyPage.keyboard.press('Control+s')
+
+      await expect
+        .poll(() => comfyPage.page.evaluate(() => window.TestCommand))
+        .toBe(true)
+
+      await comfyPage.keyboard.press('Escape')
+    })
+
     test("'Ctrl+o' triggers open workflow", async ({ comfyPage }) => {
       // Ctrl+o calls app.ui.loadFile() which clicks a hidden file input.
       // Detect the file input click via an event listener.

src/platform/keybindings/keybindingService.ts

@@ -51,6 +51,12 @@ export function useKeybindingService() {
         }
       }
       if (isModalOpen(dialogStore.dialogStack.length)) {
+        // A combo the app owns must not fall through to the browser just
+        // because a dialog is open. Only Ctrl/Cmd combos are suppressed —
+        // bare keys still have to reach inputs inside the dialog.
+        if (keyCombo.ctrl) {
+          event.preventDefault()
+        }
         return
       }