Commit 1bcfa12
fix: reset native button styles on Manage plan (FE-1668) (#15419)
## Summary
Fixes [FE-1668](https://linear.app/comfyorg/issue/FE-1668/): the
**Manage plan** item in the profile popover inherited native browser
`<button>` styling after #15266 changed it from a `<div>` to a
`<button>` for accessibility.
## Root cause
#15266 (`307c66ab5d`) added the correct keyboard and accessibility
semantics, but the button did not reset its native appearance. The
browser UA stylesheet therefore rendered a gray background, border, and
shrink-wrapped width that made this row visually inconsistent with the
neighboring menu items.
## Fix
Reset the native button appearance with `appearance-none`, `border-0`,
`bg-transparent`, `w-full`, and `text-left`. Preserve the existing hover
state and add an equivalent focus-visible state for keyboard users.
## AS IS

## TO BE

## Testing
- `pnpm exec vitest run
src/platform/workspace/components/CurrentUserPopoverWorkspace.test.ts`
(16/16 passed)
- `PLAYWRIGHT_LOCAL=1 PLAYWRIGHT_TEST_URL=http://localhost:5173 pnpm
exec playwright test
browser_tests/tests/currentUserPopoverCredits.spec.ts --project=cloud
--grep "plain full-width" --update-snapshots`
- `pnpm typecheck:browser`
- `pnpm typecheck`
- `pnpm exec oxfmt --check
browser_tests/tests/currentUserPopoverCredits.spec.ts
src/platform/workspace/components/CurrentUserPopoverWorkspace.vue`
---------
Co-authored-by: Amp <amp@ampcode.com>
Co-authored-by: github-actions <github-actions@github.com>1 parent 9d31653 commit 1bcfa12
4 files changed
Lines changed: 35 additions & 1 deletion
File tree
- browser_tests/tests
- currentUserPopoverCredits.spec.ts-snapshots
- src/platform/workspace/components
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| 11 | + | |
| 12 | + | |
11 | 13 | | |
12 | 14 | | |
13 | 15 | | |
| |||
164 | 166 | | |
165 | 167 | | |
166 | 168 | | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
167 | 201 | | |
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
153 | 153 | | |
154 | 154 | | |
155 | 155 | | |
156 | | - | |
| 156 | + | |
157 | 157 | | |
158 | 158 | | |
159 | 159 | | |
| |||
0 commit comments