perf: collapse visible error selector scans

Author: benjcooley

browser_tests/fixtures/utils/errorSurfaces.ts

@@ -39,22 +39,24 @@ function installVisibleErrorRecorder(config: {
   if (target.__cnVisibleErrors !== undefined) return
   const seen = new Set<string>()
   const errors: VisibleError[] = []
+  const combinedSelector = selectors.map(({ selector }) => selector).join(',')
   target.__cnVisibleErrors = errors
   const sample = () => {
-    for (const { surface, selector } of selectors) {
-      for (const element of document.querySelectorAll(selector)) {
-        if (
-          !(element instanceof HTMLElement) ||
-          !element.checkVisibility({
-            checkOpacity: true,
-            checkVisibilityCSS: true
-          })
-        )
-          continue
-        const text = (element.innerText || element.textContent || '')
-          .replace(/\s+/g, ' ')
-          .trim()
-          .slice(0, 300)
+    for (const element of document.querySelectorAll(combinedSelector)) {
+      if (
+        !(element instanceof HTMLElement) ||
+        !element.checkVisibility({
+          checkOpacity: true,
+          checkVisibilityCSS: true
+        })
+      )
+        continue
+      const text = (element.innerText || element.textContent || '')
+        .replace(/\s+/g, ' ')
+        .trim()
+        .slice(0, 300)
+      for (const { surface, selector } of selectors) {
+        if (!element.matches(selector)) continue
         const key = `${surface}\u0000${text}`
         if (seen.has(key)) continue
         seen.add(key)

browser_tests/tests/customNodes/connectivity.spec.ts

@@ -131,6 +131,9 @@ async function runPairsInIsolatedPages(
   const results: PairResult[] = []
   const errors: string[] = []
   for (const pair of pairs) {
+    const pairKey = `${pair.producer.nodeType}.${pair.producer.slotName} -> ${pair.consumer.nodeType}.${pair.consumer.slotName}`
+    const pairStart = Date.now()
+    console.log(`connectivity isolated pair: ${pairKey} starting`)
     const probe = await page.context().newPage()
     try {
       await trackVisibleErrors(probe)
@@ -163,6 +166,9 @@ async function runPairsInIsolatedPages(
       }
     } finally {
       if (!probe.isClosed()) await probe.close()
+      console.log(
+        `connectivity isolated pair: ${pairKey} completed in ${Date.now() - pairStart}ms`
+      )
     }
   }
   return { results, errors }
@@ -279,7 +285,11 @@ test('connectivity: representative edges cover every pairable slot through model
       isolatedPairs.length * ISOLATED_MS_PER_PAIR
   )
   const sweepStart = Date.now()
+  const sharedStart = Date.now()
   const sharedResults = await runPairsInPage(comfyPage.page, sharedPairs)
+  console.log(
+    `connectivity shared sweep: ${sharedPairs.length} pairs in ${Date.now() - sharedStart}ms`
+  )
   const isolated = await runPairsInIsolatedPages(comfyPage.page, isolatedPairs)
   const results = [...sharedResults, ...isolated.results]
   const sweepMs = Date.now() - sweepStart

browser_tests/tests/customNodes/errorSurfaces.pure.spec.ts

@@ -134,7 +134,7 @@ test('DOM churn is sampled at a fixed rate, not per mutation', async ({
               typeof globalThis & { __recorderQueries?: number }
           ).__recorderQueries
       )
-    await expect(state()).resolves.toBe(4)
+    await expect(state()).resolves.toBe(1)
 
     await probe.evaluate(() => {
       let parent = document.getElementById('root')!
@@ -145,11 +145,11 @@ test('DOM churn is sampled at a fixed rate, not per mutation', async ({
         parent = child
       }
     })
-    await expect(state()).resolves.toBe(4)
+    await expect(state()).resolves.toBe(1)
     await probe.clock.runFor(99)
-    await expect(state()).resolves.toBe(4)
+    await expect(state()).resolves.toBe(1)
     await probe.clock.runFor(1)
-    await expect(state()).resolves.toBe(8)
+    await expect(state()).resolves.toBe(2)
     await expect(
       expectNoVisibleErrors(probe, 'after DOM churn')
     ).resolves.toBeUndefined()