Commit 2e0ba75
Connor Byrne
test(first-run-tour): stop leaking queued jobs between tests
`acceptRun` wrote to a module-level holder that `beforeEach` never reset, so
every test after the first ran with a job already accepted and the deadline
suppressed rather than disarmed. Four tests asserting a reported run survives
past the deadline passed only on that leak.
The mock factories also ran on the first dynamic import — mid-test for
whichever test ran first — and replaced each holder, discarding setup that
test had already written. That made any isolated run read a null workflow and
key-miss every status lookup, so `-t`, `.only` and sharding all failed.
Verified: full file 54/54, and each affected test green on its own.
Addresses review feedback:
#15091 (comment)1 parent 9dfd953 commit 2e0ba75
1 file changed
Lines changed: 9 additions & 8 deletions
Lines changed: 9 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
47 | 47 | | |
48 | 48 | | |
49 | 49 | | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
50 | 53 | | |
51 | 54 | | |
52 | | - | |
53 | | - | |
| 55 | + | |
| 56 | + | |
54 | 57 | | |
55 | 58 | | |
56 | 59 | | |
| |||
64 | 67 | | |
65 | 68 | | |
66 | 69 | | |
67 | | - | |
68 | | - | |
69 | | - | |
70 | | - | |
| 70 | + | |
71 | 71 | | |
72 | 72 | | |
73 | 73 | | |
74 | 74 | | |
75 | 75 | | |
76 | | - | |
| 76 | + | |
77 | 77 | | |
78 | 78 | | |
79 | 79 | | |
| |||
85 | 85 | | |
86 | 86 | | |
87 | 87 | | |
88 | | - | |
| 88 | + | |
89 | 89 | | |
90 | 90 | | |
91 | 91 | | |
| |||
242 | 242 | | |
243 | 243 | | |
244 | 244 | | |
| 245 | + | |
245 | 246 | | |
246 | 247 | | |
247 | 248 | | |
| |||
0 commit comments