Skip to content

Commit 470dbe6

Browse files
ci(release): add curl timeouts in release-done job
Add --connect-timeout 10 --max-time 30 to all three curl calls in the release-done job (PyPI version check, PyPI latest, ComfyUI master pin) so a stalled external endpoint terminates promptly instead of hanging the job. Addresses CodeRabbit follow-up on #14039. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent b67cb9f commit 470dbe6

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

.github/workflows/release-biweekly-comfyui.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -544,7 +544,7 @@ jobs:
544544
545545
# --- 2. Target version is actually on PyPI ---
546546
PACKAGE="comfyui-frontend-package"
547-
HTTP_CODE=$(curl -s -o /dev/null -w "%{http_code}" "https://pypi.org/pypi/${PACKAGE}/${TARGET_VERSION}/json") || HTTP_CODE="000"
547+
HTTP_CODE=$(curl -s --connect-timeout 10 --max-time 30 -o /dev/null -w "%{http_code}" "https://pypi.org/pypi/${PACKAGE}/${TARGET_VERSION}/json") || HTTP_CODE="000"
548548
if [ "$HTTP_CODE" = "200" ]; then
549549
echo "- ✅ PyPI has \`${PACKAGE}==${TARGET_VERSION}\`" >> "$GITHUB_STEP_SUMMARY"
550550
else
@@ -557,7 +557,7 @@ jobs:
557557
# higher minor), so there this is informational only.
558558
# Guard the fetch+parse: an empty result means the query failed, which must
559559
# be reported as a fetch failure rather than masquerading as a version mismatch.
560-
PYPI_LATEST=$(curl -sf "https://pypi.org/pypi/${PACKAGE}/json" | jq -r '.info.version // empty') || PYPI_LATEST=""
560+
PYPI_LATEST=$(curl -sf --connect-timeout 10 --max-time 30 "https://pypi.org/pypi/${PACKAGE}/json" | jq -r '.info.version // empty') || PYPI_LATEST=""
561561
if [ -z "$PYPI_LATEST" ]; then
562562
echo "::error title=Could not fetch PyPI latest::Failed to query PyPI info endpoint for ${PACKAGE}."
563563
echo "- ❌ Could not determine PyPI \`latest\` version for \`${PACKAGE}\`" >> "$GITHUB_STEP_SUMMARY"
@@ -573,7 +573,7 @@ jobs:
573573
# --- 3. ComfyUI master pin (warn-only: the pin PR is merged by a human) ---
574574
# Guard the fetch: a failed download leaves PIN empty and the check stays
575575
# warn-only (reported as <none>), never aborting the job.
576-
if REQS=$(curl -sf "https://raw.githubusercontent.com/Comfy-Org/ComfyUI/master/requirements.txt"); then
576+
if REQS=$(curl -sf --connect-timeout 10 --max-time 30 "https://raw.githubusercontent.com/Comfy-Org/ComfyUI/master/requirements.txt"); then
577577
PIN=$(printf '%s\n' "$REQS" | grep -oE "comfyui-frontend-package==[0-9.]+" | head -1 | cut -d= -f3) || PIN=""
578578
else
579579
PIN=""

0 commit comments

Comments
 (0)