fix: release write fence when workspace init settles on error

onUserResolved's readiness watcher only unblocked writes when
teamWorkspaceStore.initState reached 'ready'. initState can also settle
permanently at 'error' (no workspaces available, retries exhausted), which
the watcher never accounted for -- the storage fence then stayed on for
the rest of the session with no recovery path.

Found by CodeRabbit on #14337.

Author: christian-byrne

src/platform/workflow/persistence/composables/useWorkflowPersistenceV2.test.ts

@@ -143,7 +143,7 @@ vi.mock('@/platform/distribution/types', () => ({
 }))
 
 const teamWorkspaceStoreMocks = reactive({
-  initState: 'uninitialized' as 'uninitialized' | 'ready',
+  initState: 'uninitialized' as 'uninitialized' | 'ready' | 'error',
   activeWorkspaceId: null as string | null
 })
 
@@ -881,6 +881,27 @@ describe('useWorkflowPersistenceV2', () => {
     expect(completeTransitionSpy).toHaveBeenCalledOnce()
   })
 
+  it('releases the write fence when workspace initialization fails permanently', async () => {
+    distributionMocks.isCloud = true
+    const completeTransitionSpy = vi.spyOn(
+      storageIO,
+      'completeWorkflowLogoutTransition'
+    )
+    mountWorkflowPersistence()
+
+    const onLogout = currentUserMocks.onUserLogout.mock.calls[0][0]
+    const onUserResolved = currentUserMocks.onUserResolved.mock.calls[0][0]
+    onLogout()
+    onUserResolved({ id: 'user-a' })
+
+    expect(completeTransitionSpy).not.toHaveBeenCalled()
+
+    teamWorkspaceStoreMocks.initState = 'error'
+    await nextTick()
+
+    expect(completeTransitionSpy).toHaveBeenCalledOnce()
+  })
+
   it('waits for workspace readiness and drops pending pre-logout edits', async () => {
     distributionMocks.isCloud = true
     const sourceWorkspaceId = 'workspace-a'

src/platform/workflow/persistence/composables/useWorkflowPersistenceV2.ts

@@ -158,16 +158,21 @@ export function useWorkflowPersistenceV2() {
     if (!isCloud) return
     stopPendingWorkspaceReadinessWatcher()
 
-    const isWorkspaceReady = () =>
-      teamWorkspaceStore.initState === 'ready' &&
-      teamWorkspaceStore.activeWorkspaceId !== null
-    if (isWorkspaceReady()) {
+    // Release the fence once initialization concludes either way: a resolved
+    // workspace, or a permanent init failure. Waiting on 'ready' alone would
+    // leave writes blocked for the rest of the session if init settles on
+    // 'error' (e.g. no workspaces available, retries exhausted).
+    const isWorkspaceInitConcluded = () =>
+      (teamWorkspaceStore.initState === 'ready' &&
+        teamWorkspaceStore.activeWorkspaceId !== null) ||
+      teamWorkspaceStore.initState === 'error'
+    if (isWorkspaceInitConcluded()) {
       completeWorkflowLogoutTransition()
       return
     }
 
     stopWorkspaceReadinessWatcher = whenever(
-      isWorkspaceReady,
+      isWorkspaceInitConcluded,
       () => {
         stopWorkspaceReadinessWatcher = undefined
         completeWorkflowLogoutTransition()