Merge remote-tracking branch 'origin/main' into pr-11953-x

# Conflicts:
#	browser_tests/fixtures/data/cloudWorkspace.ts
#	browser_tests/tests/dialogs/pricingTableDeepLink.spec.ts

Author: Connor Byrne

.agents/checks/pattern-compliance.md

@@ -22,6 +22,7 @@ Steps:
 - Explicit return types on exported functions
 - Use `es-toolkit` for utility functions, NOT lodash. Flag any new `import ... from 'lodash'` or `import ... from 'lodash/*'`
 - Never use `z.any()` in Zod schemas — use `z.unknown()` and narrow
+- Never hand-declare or duplicate server/API response types locally — flag any local interface/type that reimplements a type already generated from an OpenAPI spec (e.g. `@comfyorg/ingest-types`, `@comfyorg/registry-types` in `packages/`) instead of importing it. This caused real bugs in PR #14771 (see `docs/guidance/typescript.md`)
 
 ### Vue (if applicable)
 

.agents/setup

@@ -3,6 +3,11 @@ set -euo pipefail
 
 repo_root="$(cd "$(dirname "${BASH_SOURCE[0]}")/.." && pwd)"
 cd "$repo_root"
+
+if [[ "${AMP_ORB:-}" == 1 ]]; then
+  gh auth setup-git
+fi
+
 node_major="$(tr -d '[:space:]' < "$repo_root/.nvmrc")"
 node_home="$HOME/.local/share/comfyui-frontend-node-v$node_major"
 
@@ -56,16 +61,10 @@ if [[ ! -x "$node_home/bin/pnpm" ]] ||
   npm install --global --prefix "$node_home" "pnpm@$pnpm_version"
 fi
 
-profile_marker="# ComfyUI Frontend orb toolchain"
-if ! grep -Fqx "$profile_marker" "$HOME/.bash_profile" 2>/dev/null; then
-  cat >> "$HOME/.bash_profile" <<EOF
-
-$profile_marker
-if [[ "\${PWD:-}" == "$repo_root" || "\${PWD:-}" == "$repo_root/"* ]]; then
-  export PATH="$node_home/bin:\$PATH"
-fi
-EOF
-fi
+mkdir -p "$HOME/.local/bin"
+for executable in node npm npx pnpm pnpx; do
+  ln -sfn "$node_home/bin/$executable" "$HOME/.local/bin/$executable"
+done
 
 echo "Installing workspace dependencies"
 pnpm install --frozen-lockfile

.amp/services.yaml

@@ -0,0 +1,6 @@
+services:
+  frontend:
+    command: pnpm dev:cloud --host 0.0.0.0 --port "$PORT"
+    portal:
+      title: ComfyUI Frontend
+      description: Frontend dev server connected to the Comfy test cloud backend.

.claude/commands/comprehensive-pr-review.md

@@ -146,6 +146,7 @@ Look for:
 - Proper abstraction levels
 - Interface design and API clarity
 - Leftover debug code (console.log, commented code, TODO comments)
+- Hand-declared/inlined server or API response types that duplicate a type already generated from an OpenAPI spec (`@comfyorg/ingest-types`, `@comfyorg/registry-types` under `packages/`) instead of importing it — these silently drift from the real contract and caused real bugs in PR #14771
 
 ### 3.3 Library Usage Enforcement
 

.github/actions/lint-format-verify/action.yml

@@ -1,22 +1,14 @@
 name: 'Lint and format verify'
 description: >
-  Runs the lint/format/knip verification suite plus a conditional
-  browser-tests typecheck. Shared by ci-lint-format.yaml (PR) and
+  Runs the lint/format/knip verification suite plus the browser-tests
+  typecheck. Shared by ci-lint-format.yaml (PR) and
   ci-lint-format-queue.yaml (merge queue) so both paths run the exact
   same checks. The caller is responsible for checkout and frontend setup
   before invoking this action.
 
 runs:
   using: composite
   steps:
-    - name: Detect browser_tests changes
-      id: changed-paths
-      uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
-      with:
-        filters: |
-          browser_tests:
-            - 'browser_tests/**'
-
     - name: Verify lint and format
       shell: bash
       run: |
@@ -26,6 +18,5 @@ runs:
         pnpm knip
 
     - name: Typecheck browser tests
-      if: steps.changed-paths.outputs.browser_tests == 'true'
       shell: bash
       run: pnpm typecheck:browser

.github/actions/setup-frontend/action.yaml

@@ -12,7 +12,7 @@ runs:
 
     # Install pnpm, Node.js, build frontend
     - name: Install pnpm
-      uses: pnpm/action-setup@fc06bc1257f339d1d5d8b3a19a8cae5388b55320 # v4.4.0
+      uses: pnpm/action-setup@0ebf47130e4866e96fce0953f49152a61190b271 # v6.0.9
 
     - name: Setup Node.js
       uses: actions/setup-node@v6

.github/workflows/api-update-electron-api-types.yaml

@@ -16,7 +16,7 @@ jobs:
         uses: actions/checkout@v6
 
       - name: Install pnpm
-        uses: pnpm/action-setup@fc06bc1257f339d1d5d8b3a19a8cae5388b55320 # v4.4.0
+        uses: pnpm/action-setup@0ebf47130e4866e96fce0953f49152a61190b271 # v6.0.9
 
       - name: Setup Node.js
         uses: actions/setup-node@v6

.github/workflows/api-update-manager-api-types.yaml

@@ -21,7 +21,7 @@ jobs:
         uses: actions/checkout@v6
 
       - name: Install pnpm
-        uses: pnpm/action-setup@fc06bc1257f339d1d5d8b3a19a8cae5388b55320 # v4.4.0
+        uses: pnpm/action-setup@0ebf47130e4866e96fce0953f49152a61190b271 # v6.0.9
 
       - name: Setup Node.js
         uses: actions/setup-node@v6

.github/workflows/ci-dist-telemetry-scan.yaml

@@ -32,7 +32,7 @@ jobs:
       - uses: actions/checkout@v6
 
       - name: Install pnpm
-        uses: pnpm/action-setup@fc06bc1257f339d1d5d8b3a19a8cae5388b55320 # v4.4.0
+        uses: pnpm/action-setup@0ebf47130e4866e96fce0953f49152a61190b271 # v6.0.9
 
       - name: Use Node.js
         uses: actions/setup-node@v6

.github/workflows/ci-oss-assets-validation.yaml

@@ -33,7 +33,7 @@ jobs:
       - uses: actions/checkout@v6
 
       - name: Install pnpm
-        uses: pnpm/action-setup@fc06bc1257f339d1d5d8b3a19a8cae5388b55320 # v4.4.0
+        uses: pnpm/action-setup@0ebf47130e4866e96fce0953f49152a61190b271 # v6.0.9
 
       - name: Use Node.js
         uses: actions/setup-node@v6
@@ -52,24 +52,24 @@ jobs:
       - name: Check for proprietary fonts in dist
         run: |
           set -euo pipefail
-          echo '🔍 Checking dist for proprietary ABCROM fonts...'
+          echo '🔍 Checking dist for proprietary fonts...'
 
           if [ ! -d "dist" ] || [ -z "$(ls -A dist)" ]; then
             echo '❌ ERROR: dist/ directory missing or empty!'
             exit 1
           fi
 
-          # Check for ABCROM font files
-          if find dist/ -type f -iname '*abcrom*' \
+          # Check for ABCROM and PP Formula font files
+          if find dist/ -type f \( -iname '*abcrom*' -o -iname '*ppformula*' \) \
             \( -name '*.woff' -o -name '*.woff2' -o -name '*.ttf' -o -name '*.otf' \) \
             -print -quit | grep -q .; then
             echo ''
-            echo '❌ ERROR: Found proprietary ABCROM font files in dist!'
+            echo '❌ ERROR: Found proprietary font files in dist!'
             echo ''
-            find dist/ -type f -iname '*abcrom*' \
+            find dist/ -type f \( -iname '*abcrom*' -o -iname '*ppformula*' \) \
               \( -name '*.woff' -o -name '*.woff2' -o -name '*.ttf' -o -name '*.otf' \)
             echo ''
-            echo 'ABCROM fonts are proprietary and should not ship to OSS builds.'
+            echo 'ABCROM and PP Formula fonts are proprietary and should not ship to OSS builds.'
             echo ''
             echo 'To fix this:'
             echo '1. Use conditional font loading based on isCloud'
@@ -88,7 +88,7 @@ jobs:
       - uses: actions/checkout@v6
 
       - name: Install pnpm
-        uses: pnpm/action-setup@fc06bc1257f339d1d5d8b3a19a8cae5388b55320 # v4.4.0
+        uses: pnpm/action-setup@0ebf47130e4866e96fce0953f49152a61190b271 # v6.0.9
 
       - name: Use Node.js
         uses: actions/setup-node@v6