fix: close the error overlay when the active graph changes

clean() used to call clearRunErrors(), which also reset isErrorOverlayOpen.
setActiveGraph(null) left that global bit set, so a destination workflow whose
cached missing-model/media warnings are restored with silent: true would still
pop the overlay.

setActiveGraph() now dismisses the overlay on every move, restoring the old
clean() behaviour and keeping it scoped to the graph in front.

Addresses #15361 (comment)

Author: christian-byrne

src/stores/executionErrorStore.test.ts

@@ -963,6 +963,20 @@ describe('setActiveGraph', () => {
     expect(store.lastNodeErrors).toBeNull()
   })
 
+  it('closes the error overlay when the active graph changes', () => {
+    const store = useExecutionErrorStore()
+
+    store.setActiveGraph(graphAId)
+    store.recordNodeErrors(nodeErrors)
+    store.showErrorOverlay()
+
+    store.setActiveGraph(null)
+    expect(store.isErrorOverlayOpen).toBe(false)
+
+    store.setActiveGraph(graphAId)
+    expect(store.isErrorOverlayOpen).toBe(false)
+  })
+
   it('ignores errors recorded while no graph is active', () => {
     const store = useExecutionErrorStore()
 

src/stores/executionErrorStore.ts

@@ -70,6 +70,7 @@ export const useExecutionErrorStore = defineStore('executionError', () => {
    */
   const runErrorsByGraphId = ref(new Map<UUID, RunErrorState>())
   const activeGraphId = ref<UUID | null>(zeroUuid)
+  const isErrorOverlayOpen = ref(false)
 
   const activeRunErrors = computed<RunErrorState | undefined>(() =>
     activeGraphId.value === null
@@ -108,13 +109,15 @@ export const useExecutionErrorStore = defineStore('executionError', () => {
 
   /**
    * Point the store at the run errors of `graphId`. `null` detaches it, so a
-   * discarded graph shows nothing until the next one is loaded.
+   * discarded graph shows nothing until the next one is loaded. The overlay is
+   * dismissed on every move so it only ever reopens for the graph in front.
    */
   function setActiveGraph(graphId: UUID | null) {
+    if (graphId === activeGraphId.value) return
     activeGraphId.value = graphId
+    isErrorOverlayOpen.value = false
   }
 
-  const isErrorOverlayOpen = ref(false)
   const pendingAddedNodeScans = new WeakMap<
     LGraph,
     Map<NodeExecutionId, number>