Skip to content

Commit 999742d

Browse files
committed
ci: point website path rule at the coverage source of truth
The exception list named only content, i18n and content.config.ts, but coverage.exclude also drops test/spec files, stories, .d.ts and src/test/**. The glob apps/website/src/**/*.{ts,vue} matches all of them, so 68 files (41 tests, 25 stories, 1 declaration, 1 setup) would have been told their lines are measured by the website-unit gate when they are not. Cite vitest.config.ts as the source of truth rather than only restating its contents, so the guidance degrades to "go look" instead of silently becoming wrong when that list changes.
1 parent bd1dfb2 commit 999742d

1 file changed

Lines changed: 6 additions & 3 deletions

File tree

.coderabbit.yaml

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -131,9 +131,12 @@ reviews:
131131
status, so new behaviour needs a colocated Vitest test. Treat
132132
`docs/guidance/vitest.md` as required review context. Flag new
133133
exported logic that no test exercises.
134-
Exception: `src/content/**`, `src/i18n/**` and `src/content.config.ts`
135-
are excluded from coverage in `apps/website/vitest.config.ts`, so do
136-
not invoke the `website-unit` gate for changes confined to those.
134+
This glob is wider than the gate: `coverage.exclude` in
135+
`apps/website/vitest.config.ts` is the source of truth, and anything
136+
it lists is unmeasured. At time of writing that is `*.test.ts`,
137+
`*.spec.ts`, `*.stories.ts`, `*.d.ts`, `src/test/**`,
138+
`src/content/**`, `src/i18n/**` and `src/content.config.ts`. Do not
139+
cite the `website-unit` gate for changes confined to those.
137140
- path: 'apps/website/src/**/*.astro'
138141
instructions: |
139142
`.astro` files are excluded from coverage because V8 cannot

0 commit comments

Comments
 (0)