fix: drop non-string translation values and trim malformed retries

Keep valid strings when a batch response contains a non-string value so the
missing ids route through the existing retry-note rounds instead of failing
the locale. Cut malformed-response retries to one, and report the locales
that actually have pending work in the translation preflight.

Author: benceruleanlu

scripts/i18n/translate.ts

@@ -18,7 +18,7 @@ export type TranslateBatch = (
 
 const defaultRequestTimeoutMs = 120_000
 const maxNetworkRetries = 3
-const maxMalformedResponseRetries = 3
+const maxMalformedResponseRetries = 1
 
 // Unlike es-toolkit's mapAsync, which dispatches every item up front, this
 // pool stops dispatching once any task fails so a fatal error does not keep
@@ -54,8 +54,6 @@ export function chunkItems(
   maxItems: number,
   maxSourceChars: number
 ): TranslationItem[][] {
-  // Character count is an initial batching heuristic; truncated responses are
-  // recursively split before the translation run fails.
   const chunks: TranslationItem[][] = []
   let chunk: TranslationItem[] = []
   let chunkChars = 0
@@ -101,18 +99,8 @@ function parseBatchResponse(content: string): Record<string, string> {
     throw new Error('translation response is not a JSON object')
   }
   const record: Record<string, string> = {}
-  const invalidIds: string[] = []
   for (const [key, value] of Object.entries(parsed)) {
-    if (typeof value === 'string') {
-      record[key] = value
-    } else {
-      invalidIds.push(key)
-    }
-  }
-  if (invalidIds.length > 0) {
-    throw new Error(
-      `translation response has non-string values for ids: ${invalidIds.join(', ')}`
-    )
+    if (typeof value === 'string') record[key] = value
   }
   return record
 }

scripts/i18n/update-locales.test.ts

@@ -580,18 +580,23 @@ describe('createOpenAiTranslator', () => {
     expect(callCount()).toBe(1)
   })
 
-  it('reports non-string response values with their ids', async () => {
-    const malformed = () => completion('{"1": {"text": "Bonjour"}, "2": 42}')
+  it('drops non-string values instead of failing the whole batch', async () => {
     const { translate, callCount } = translatorFor([
-      malformed(),
-      malformed(),
-      malformed(),
-      malformed()
+      completion('{"1": "Bonjour {name}", "2": 42}')
     ])
-    await expect(translate(locale, items)).rejects.toThrow(
-      'translation response has non-string values for ids: 1, 2'
-    )
-    expect(callCount()).toBe(4)
+    await expect(translate(locale, items)).resolves.toEqual({
+      '1': 'Bonjour {name}'
+    })
+    expect(callCount()).toBe(1)
+  })
+
+  it('stops after one retry on a malformed response', async () => {
+    const { translate, callCount } = translatorFor([
+      completion('not json'),
+      completion('not json')
+    ])
+    await expect(translate(locale, items)).rejects.toThrow()
+    expect(callCount()).toBe(2)
   })
 
   it('reports usage for every completed API request', async () => {

scripts/i18n/update-locales.ts

@@ -469,8 +469,11 @@ async function run(argv: readonly string[]): Promise<void> {
     (count, plan) => count + plan.items.length,
     0
   )
-  const initialBatchCount = [...translationPlans.values()].reduce(
-    (count, plan) =>
+  const pendingPlans = [...translationPlans].filter(
+    ([, plan]) => plan.items.length > 0
+  )
+  const initialBatchCount = pendingPlans.reduce(
+    (count, [, plan]) =>
       count +
       chunkItems(
         plan.items,
@@ -479,9 +482,12 @@ async function run(argv: readonly string[]): Promise<void> {
       ).length,
     0
   )
+  const pendingLocaleCount = new Set(
+    pendingPlans.map(([state]) => state.locale.code)
+  ).size
   if (pendingTotal > 0) {
     print(
-      `Translation preflight: ${pendingTotal} strings in ${initialBatchCount} initial batches across ${config.outputLocales.length} locales; retries and truncation splits can add requests.`
+      `Translation preflight: ${pendingTotal} strings in ${initialBatchCount} initial batches across ${pendingLocaleCount} locales; retries and truncation splits can add requests.`
     )
   }