test: extract node title viewport wait

Amp-Thread-ID: https://ampcode.com/threads/T-01a0165c-6e78-7117-9a54-4514124737d7
Co-authored-by: Amp <amp@ampcode.com>

Author: DrJKL

browser_tests/fixtures/utils/litegraphUtils.ts

@@ -356,6 +356,20 @@ export class NodeReference {
     const nodeSize = await this.getSize()
     return { x: nodePos.x + nodeSize.width / 2, y: nodePos.y - 15 }
   }
+  async waitForTitleInView(): Promise<void> {
+    const canvas = await this.comfyPage.canvas.boundingBox()
+    if (!canvas) throw new Error('Canvas bounding box not available')
+
+    let previousX = Number.NaN
+    await expect
+      .poll(async () => {
+        const { x } = await this.getTitlePosition()
+        const settledInView = x === previousX && x < canvas.width
+        previousX = x
+        return settledInView
+      })
+      .toBe(true)
+  }
   async dragBy(
     delta: Position,
     options?: {

browser_tests/tests/subgraph/subgraphCreationBoundaryLinks.spec.ts

@@ -2,24 +2,24 @@ import { expect } from '@playwright/test'
 
 import { comfyPageFixture as test } from '@e2e/fixtures/ComfyPage'
 
+const SUBGRAPH_LINKS_EXPECTED = {
+  rootLinks: [
+    '4:0->HOST:0',
+    '4:1->6:0',
+    '4:1->7:0',
+    '4:2->HOST:4',
+    '5:0->HOST:3',
+    '6:0->HOST:1',
+    '7:0->HOST:2',
+    'HOST:0->9:0'
+  ],
+  incompatibleHostInputLinks: []
+} as const
+
 test(
   'Subgraph creation rewires boundary links to compatible slots across reload',
   { tag: ['@slow', '@subgraph', '@vue-nodes'] },
   async ({ comfyPage }) => {
-    const expectedSnapshot = {
-      rootLinks: [
-        '4:0->HOST:0',
-        '4:1->6:0',
-        '4:1->7:0',
-        '4:2->HOST:4',
-        '5:0->HOST:3',
-        '6:0->HOST:1',
-        '7:0->HOST:2',
-        'HOST:0->9:0'
-      ],
-      incompatibleHostInputLinks: []
-    }
-
     await test.step('Select both nodes in the default workflow', async () => {
       await comfyPage.settings.setSetting('Comfy.UseNewMenu', 'Disabled')
       await comfyPage.workflow.loadWorkflow('default')
@@ -29,16 +29,7 @@ test(
       // holding KSampler alone.
       await comfyPage.command.executeCommand('Comfy.Canvas.FitView')
       const vaeDecode = await comfyPage.nodeOps.getNodeRefById('8')
-      const canvasWidth = (await comfyPage.canvas.boundingBox())!.width
-      let previousX = Number.NaN
-      await expect
-        .poll(async () => {
-          const { x } = await vaeDecode.getTitlePosition()
-          const settledInView = x === previousX && x < canvasWidth
-          previousX = x
-          return settledInView
-        })
-        .toBe(true)
+      await vaeDecode.waitForTitleInView()
 
       await comfyPage.nodeOps.selectNodes(['KSampler', 'VAE Decode'])
       expect(
@@ -53,15 +44,15 @@ test(
 
       await expect
         .poll(() => comfyPage.subgraph.getBoundaryLinkSnapshot())
-        .toEqual(expectedSnapshot)
+        .toEqual(SUBGRAPH_LINKS_EXPECTED)
     })
 
     await test.step('Reload and verify the boundary links', async () => {
       await comfyPage.subgraph.serializeAndReload()
 
       await expect
         .poll(() => comfyPage.subgraph.getBoundaryLinkSnapshot())
-        .toEqual(expectedSnapshot)
+        .toEqual(SUBGRAPH_LINKS_EXPECTED)
     })
   }
 )