refactor: type toSerializable() as serialized data, not the class

The return type was `ComfyNodeDefImpl & { display_name; description }`, which
promised `nodePath`, `nodeLifeCycleBadgeText` and `toSerializable` on an object
`Object.assign` never copies them onto — the same accessor-vs-runtime gap this
PR exists to close.

`SerializableComfyNodeDef` omits every accessor and method, so reading one off a
serialized def is now a compile error rather than a runtime undefined.

Author: christian-byrne

src/stores/nodeDefStore.serialization.test.ts

@@ -43,4 +43,14 @@ describe('ComfyNodeDefImpl.toSerializable', () => {
     expect(crossed.display_name).toBeUndefined()
     expect(crossed.description).toBeUndefined()
   })
+
+  it('emits no other accessor, so the type must not promise one', () => {
+    const serialized: Record<string, unknown> = new ComfyNodeDefImpl(
+      backendDef
+    ).toSerializable()
+
+    expect(serialized.nodePath).toBeUndefined()
+    expect(serialized.nodeLifeCycleBadgeText).toBeUndefined()
+    expect(serialized.toSerializable).toBeUndefined()
+  })
 })

src/stores/nodeDefStore.ts

@@ -214,10 +214,7 @@ export class ComfyNodeDefImpl
    * arrive `undefined` — which is how the release locale collector would have
    * written every node's `display_name` as its internal `name`.
    */
-  toSerializable(): ComfyNodeDefImpl & {
-    display_name: string
-    description: string
-  } {
+  toSerializable(): SerializableComfyNodeDef {
     return Object.assign({}, this, {
       display_name: this.display_name,
       description: this.description
@@ -246,6 +243,22 @@ export class ComfyNodeDefImpl
   }
 }
 
+/**
+ * What `toSerializable()` emits: own data properties plus the two resolved
+ * strings. `Object.assign` copies neither accessors nor methods, so naming them
+ * here would repeat the defect this type exists to prevent.
+ */
+export type SerializableComfyNodeDef = Omit<
+  ComfyNodeDefImpl,
+  | 'display_name'
+  | 'description'
+  | 'nodePath'
+  | 'isDummyFolder'
+  | 'nodeLifeCycleBadgeText'
+  | 'postProcessSearchScores'
+  | 'toSerializable'
+> & { display_name: string; description: string }
+
 export const SYSTEM_NODE_DEFS: Record<string, ComfyNodeDefV1> = {
   PrimitiveNode: {
     name: 'PrimitiveNode',