fix(onboarding): re-check the canvas after the intro preview

Review feedback on #14673.

The entry guard runs before `beginTour` awaits the renderer write and the
500 ms intro preview, so a switch into linear mode inside that window
still opened the tour: the holds watcher fires while `activeTour` is
still null, so it has nothing to end, and `engine.startTour` does not
consult holds on the way in. Re-check before starting; the existing
`!started` path already hands the renderer switch back.

Also spy on `settingStore.set` rather than only reading the resulting
value, so a refusal that flipped `Comfy.VueNodes.Enabled` and put it back
can no longer pass as one that never touched it.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

Author: 2 people

src/renderer/extensions/firstRunTour/tour/useFirstRunTourController.test.ts

@@ -25,6 +25,7 @@ const mocks = vi.hoisted(() => ({
   activeWorkflow: { value: null as unknown },
   linearMode: { value: false },
   vueNodesEnabled: true,
+  setSetting: vi.fn(),
   steps: [] as CoachStep[],
   runState: { value: 'idle' } as Ref<string>,
   releaseFirstRunTargets: vi.fn(),
@@ -94,10 +95,9 @@ vi.mock('@/renderer/core/canvas/canvasStore', async () => {
 vi.mock('@/platform/settings/settingStore', () => ({
   useSettingStore: () => ({
     get: () => mocks.vueNodesEnabled,
-    set: (_key: string, value: boolean) => {
-      mocks.vueNodesEnabled = value
-      return Promise.resolve()
-    }
+    // A spy, not a plain writer: a value that was flipped and put back reads
+    // the same as one that was never touched.
+    set: mocks.setSetting
   })
 }))
 
@@ -238,6 +238,10 @@ describe('useFirstRunTourController', () => {
     mocks.activeWorkflow.value = null
     mocks.linearMode.value = false
     mocks.vueNodesEnabled = true
+    mocks.setSetting.mockImplementation((_key: string, value: boolean) => {
+      mocks.vueNodesEnabled = value
+      return Promise.resolve()
+    })
     mocks.steps = []
     mocks.engine.activeTour = null
     mocks.engine.lastEnding = null
@@ -339,9 +343,9 @@ describe('useFirstRunTourController', () => {
         'the cards would sit over a hidden canvas until their targets timed out'
       ).not.toHaveBeenCalled()
       expect(
-        mocks.vueNodesEnabled,
-        'a tour that never opened must not leave the renderer switched behind it'
-      ).toBe(false)
+        mocks.setSetting,
+        'a tour that never opened must not touch the renderer setting at all'
+      ).not.toHaveBeenCalledWith('Comfy.VueNodes.Enabled', true)
     })
 
     it('refuses to open on a viewport below the desktop layout', async () => {
@@ -358,7 +362,30 @@ describe('useFirstRunTourController', () => {
         'the spotlights are placed against a desktop layout, so below md they point nowhere'
       ).toBe(false)
       expect(mocks.engine.startTour).not.toHaveBeenCalled()
-      expect(mocks.vueNodesEnabled).toBe(false)
+      expect(mocks.setSetting).not.toHaveBeenCalledWith(
+        'Comfy.VueNodes.Enabled',
+        true
+      )
+    })
+
+    it('refuses to open when the canvas goes away during the intro preview', async () => {
+      mocks.vueNodesEnabled = false
+      mocks.steps = [runStep()]
+      const controller = await freshController()
+
+      const starting = controller.beginTour('image_z_image_turbo')
+      mocks.linearMode.value = true
+      await vi.advanceTimersByTimeAsync(INTRO_PREVIEW_MS)
+
+      expect(
+        await starting,
+        'the holds watcher cannot catch this — there is no active tour to end yet'
+      ).toBe(false)
+      expect(mocks.engine.startTour).not.toHaveBeenCalled()
+      expect(
+        mocks.vueNodesEnabled,
+        'the renderer switch thrown for a tour that never opened is handed back'
+      ).toBe(false)
     })
 
     it('leaves the workflow undimmed before taking the screen over', async () => {

src/renderer/extensions/firstRunTour/tour/useFirstRunTourController.ts

@@ -171,7 +171,10 @@ function useFirstRunTourControllerInternal() {
       tourContextHolds
     )
     await delay(INTRO_PREVIEW_MS)
-    const started = await engine.startTour('firstRun')
+    // The preview is long enough for the canvas to go away underneath it, and
+    // the holds watcher cannot catch that: there is no active tour to end yet.
+    const started =
+      canvasContextHolds.value && (await engine.startTour('firstRun'))
     if (!started) {
       releaseFirstRunTargets()
       tourWorkflow.value = null