test: add failing repro for run acknowledgement queued behind outcome banners

A queue notification banner holds the screen for 4s and new notifications
are appended to a FIFO. A run the user just triggered is therefore not
acknowledged until every already-queued outcome banner has drained, so
clicking Run after a batch of failures looks like it did nothing.

Author: Connor Byrne

browser_tests/tests/queueNotificationBanners.spec.ts

@@ -1,8 +1,16 @@
 import type { Page } from '@playwright/test'
-import { expect } from '@playwright/test'
-
-import { comfyPageFixture as test } from '@e2e/fixtures/ComfyPage'
+import { expect, mergeTests } from '@playwright/test'
+
+import { comfyPageFixture } from '@e2e/fixtures/ComfyPage'
+import { ExecutionHelper } from '@e2e/fixtures/helpers/ExecutionHelper'
+import {
+  createRouteMockJob,
+  jobsRouteFixture
+} from '@e2e/fixtures/jobsRouteFixture'
 import { TestIds } from '@e2e/fixtures/selectors'
+import { webSocketFixture } from '@e2e/fixtures/ws'
+
+const test = mergeTests(comfyPageFixture, webSocketFixture, jobsRouteFixture)
 
 // Mirrors BANNER_DISMISS_DELAY_MS in src/composables/queue/useQueueNotificationBanners.ts.
 // Duplicated here to avoid pulling production source (and its litegraph
@@ -147,6 +155,37 @@ test.describe('Queue notification banners', { tag: ['@ui'] }, () => {
     })
   })
 
+  test.describe('Run acknowledgement priority', () => {
+    test('a new run is acknowledged over an outcome banner still on screen', async ({
+      comfyPage,
+      getWebSocket,
+      jobsRoutes
+    }) => {
+      const failedJobId = 'failed-job-1'
+      await jobsRoutes.mockJobsHistory([
+        createRouteMockJob({
+          id: failedJobId,
+          status: 'failed',
+          execution_end_time: Date.now()
+        })
+      ])
+
+      const exec = new ExecutionHelper(comfyPage, await getWebSocket())
+      exec.executionStart(failedJobId)
+      exec.executionError(failedJobId, '1', 'boom')
+      exec.status(0)
+
+      const banner = bannerLocator(comfyPage.page)
+      await expect(banner).toContainText('failed', {
+        timeout: BANNER_ASSERT_TIMEOUT_MS
+      })
+
+      await dispatchPromptQueueing(comfyPage.page)
+
+      await expect(banner).toContainText('queuing')
+    })
+  })
+
   test.describe('Direct queued event (no pending predecessor)', () => {
     test('promptQueued without prior queueing shows queued banner directly', async ({
       comfyPage

src/composables/queue/useQueueNotificationBanners.test.ts

@@ -343,4 +343,80 @@ describe(useQueueNotificationBanners, () => {
       unmount()
     }
   })
+
+  it('acknowledges a new run over an outcome notification still on screen', async () => {
+    const { unmount, composable } = mountComposable()
+
+    try {
+      await runBatch({
+        start: 5_000,
+        finish: 5_100,
+        tasks: [createTask({ state: 'Failed', ts: 5_050 })]
+      })
+
+      expect(composable.currentNotification.value).toEqual({
+        type: 'failed',
+        count: 1
+      })
+
+      mockApi.dispatchEvent(
+        new CustomEvent('promptQueueing', {
+          detail: { requestId: 7, batchCount: 1 }
+        })
+      )
+      await nextTick()
+
+      expect(composable.currentNotification.value).toEqual({
+        type: 'queuedPending',
+        count: 1,
+        requestId: 7
+      })
+    } finally {
+      unmount()
+    }
+  })
+
+  it('acknowledges a new run ahead of outcome notifications still waiting', async () => {
+    const { unmount, composable } = mountComposable()
+
+    try {
+      await runBatch({
+        start: 6_000,
+        finish: 6_100,
+        tasks: [
+          createTask({ ts: 6_050 }),
+          createTask({ state: 'Failed', ts: 6_060 })
+        ]
+      })
+
+      expect(composable.currentNotification.value).toEqual({
+        type: 'completed',
+        count: 1,
+        thumbnailUrls: []
+      })
+
+      mockApi.dispatchEvent(
+        new CustomEvent('promptQueueing', {
+          detail: { requestId: 8, batchCount: 1 }
+        })
+      )
+      await nextTick()
+
+      expect(composable.currentNotification.value).toEqual({
+        type: 'queuedPending',
+        count: 1,
+        requestId: 8
+      })
+
+      await vi.advanceTimersByTimeAsync(4000)
+      await nextTick()
+
+      expect(composable.currentNotification.value).toEqual({
+        type: 'failed',
+        count: 1
+      })
+    } finally {
+      unmount()
+    }
+  })
 })