fix(billing): read the top-up deep link gate from billing policy

The loader computed its own gate from isActiveSubscription and isFreeTier
under a comment saying it was the negation of showTopUpCreditsDialog's
paywall gate. That stopped being true once the dialog moved to
billingPolicyCapabilities: the loader has no distribution term, so off
cloud it suppressed add_api_credit_button_clicked for deep links that do
open the real top-up dialog.

Both now read topUpAccess, so they cannot disagree.

Fixes #14862

Author: Connor Byrne

src/platform/cloud/subscription/composables/useTopUpUrlLoader.test.ts

@@ -46,11 +46,19 @@ vi.mock('@/platform/workspace/composables/useWorkspaceUI', () => ({
   useWorkspaceUI: () => ({ permissions: mockPermissions })
 }))
 
+const mockIsCloud = vi.hoisted(() => ({ value: true }))
+vi.mock('@/platform/distribution/types', () => ({
+  get isCloud() {
+    return mockIsCloud.value
+  }
+}))
+
 const mockBilling = vi.hoisted(() => ({
   fetchStatus: vi.fn().mockResolvedValue(undefined),
   subscription: { value: { isActive: true } as { isActive: boolean } | null },
-  isActiveSubscription: { value: true },
-  isFreeTier: { value: false }
+  canAccessSubscriptionFeatures: { value: true },
+  isTeamPlan: { value: false },
+  tier: { value: 'STANDARD' as string | null }
 }))
 
 vi.mock('@/composables/billing/useBillingContext', () => ({
@@ -73,8 +81,10 @@ describe('useTopUpUrlLoader', () => {
     // clearAllMocks resets calls, not implementations, so restore the defaults.
     mockBilling.fetchStatus.mockResolvedValue(undefined)
     mockBilling.subscription.value = { isActive: true }
-    mockBilling.isActiveSubscription.value = true
-    mockBilling.isFreeTier.value = false
+    mockIsCloud.value = true
+    mockBilling.canAccessSubscriptionFeatures.value = true
+    mockBilling.isTeamPlan.value = false
+    mockBilling.tier.value = 'STANDARD'
     mockShowTopUpCreditsDialog.mockResolvedValue(undefined)
     preservedQueryMocks.mergePreservedQueryIntoQuery.mockReturnValue(null)
   })
@@ -154,11 +164,22 @@ describe('useTopUpUrlLoader', () => {
     expect(mockRouterReplace).toHaveBeenCalledWith({ query: {} })
   })
 
-  it('opens without deep_link telemetry for a lapsed or free-tier user', async () => {
+  it('opens without deep_link telemetry for a lapsed user', async () => {
     mockRouteQuery.value = { topup: '1' }
     // showTopUpCreditsDialog routes this user to the paywall internally; the
     // deep_link source must only count real top-up dialog opens.
-    mockBilling.isActiveSubscription.value = false
+    mockBilling.canAccessSubscriptionFeatures.value = false
+
+    const { loadTopUpFromUrl } = useTopUpUrlLoader()
+    await loadTopUpFromUrl()
+
+    expect(mockShowTopUpCreditsDialog).toHaveBeenCalledOnce()
+    expect(mockTrackAddApiCreditButtonClicked).not.toHaveBeenCalled()
+  })
+
+  it('opens without deep_link telemetry for a free-tier user', async () => {
+    mockRouteQuery.value = { topup: '1' }
+    mockBilling.tier.value = 'FREE'
 
     const { loadTopUpFromUrl } = useTopUpUrlLoader()
     await loadTopUpFromUrl()
@@ -167,6 +188,19 @@ describe('useTopUpUrlLoader', () => {
     expect(mockTrackAddApiCreditButtonClicked).not.toHaveBeenCalled()
   })
 
+  it('emits deep_link telemetry for a free-tier user off Cloud, where top-up is allowed', async () => {
+    mockRouteQuery.value = { topup: '1' }
+    mockIsCloud.value = false
+    mockBilling.tier.value = 'FREE'
+
+    const { loadTopUpFromUrl } = useTopUpUrlLoader()
+    await loadTopUpFromUrl()
+
+    expect(mockTrackAddApiCreditButtonClicked).toHaveBeenCalledWith({
+      source: 'deep_link'
+    })
+  })
+
   it('is a silent no-op for a team member', async () => {
     mockRouteQuery.value = { topup: '1' }
     mockPermissions.value = { canTopUp: false }

src/platform/cloud/subscription/composables/useTopUpUrlLoader.ts

@@ -1,6 +1,7 @@
 import { useRoute, useRouter } from 'vue-router'
 
 import { useBillingContext } from '@/composables/billing/useBillingContext'
+import { useBillingPolicyCapabilities } from '@/platform/cloud/subscription/composables/useBillingPolicyCapabilities'
 import {
   clearPreservedQuery,
   hydratePreservedQuery,
@@ -28,6 +29,7 @@ export function useTopUpUrlLoader() {
   const router = useRouter()
   const dialogService = useDialogService()
   const billingContext = useBillingContext()
+  const { billingPolicyCapabilities } = useBillingPolicyCapabilities()
   const { permissions } = useWorkspaceUI()
   const telemetry = useTelemetry()
 
@@ -73,13 +75,10 @@ export function useTopUpUrlLoader() {
     // all overlaps with the swallowed-failure case guarded here.
     if (!billingContext.subscription.value) return
 
-    // Emit deep_link only for opens of the real top-up dialog, matching the
-    // other sources whose buttons render only for active paid users. This is
-    // the negation of the paywall gate in showTopUpCreditsDialog
-    // (dialogService.ts); keep the two in sync.
+    // Emit deep_link only for opens of the real top-up dialog, not for opens
+    // that divert to the paywall.
     const willOpenTopUpMode =
-      billingContext.isActiveSubscription.value &&
-      !billingContext.isFreeTier.value
+      billingPolicyCapabilities.value.topUpAccess === 'allowed'
     if (willOpenTopUpMode) {
       telemetry?.trackAddApiCreditButtonClicked({ source: 'deep_link' })
     }