Skip to content

Commit decfd52

Browse files
mattmilleraiclaude
andcommitted
test: drop the ColorOverlay duplicate-registration ledger entry
The custom-node console ledger (#15225, landed on main after this branch was cut) requires the ColorOverlay duplicate-registration error to be observed at startup: requiredStartupId: 'duplicate-color-overlay' pattern: /\[vite:preloadError\].*Extension named 'ColorOverlay' already registered\./ That error was the throw this PR removes. Registering a duplicate name now warns and skips, so dz_node_palette.js finishes evaluating and emits no preloadError - the pattern can never match again, since the message it matches no longer exists in the frontend. Left in place, staleRequiredStartupErrorRulesForPacks would report ComfyUI_LayerStyle_Advance/duplicate-color-overlay and fail the nightly suite's stale-rule assertion. Removing the entry is the ledger's documented lifecycle for a mechanism that stops firing, and it tightens rather than loosens the gate: the pack no longer carries a suppression, so a duplicate-registration error reappearing would surface as unallowlisted. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
1 parent b8d83f4 commit decfd52

1 file changed

Lines changed: 0 additions & 13 deletions

File tree

browser_tests/fixtures/customNode/consoleErrorLedger.ts

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -170,19 +170,6 @@ const CONSOLE_ERROR_ALLOWLIST: Record<string, AllowlistRule[]> = {
170170
'skip metadata requests without a node name and remove this entry'
171171
}
172172
],
173-
ComfyUI_LayerStyle_Advance: [
174-
{
175-
id: 'duplicate-color-overlay',
176-
pattern:
177-
/\[vite:preloadError\].*Extension named 'ColorOverlay' already registered\./,
178-
global: true,
179-
requiredStartupId: 'duplicate-color-overlay',
180-
reason:
181-
'this pack and comfyui_layerstyle both register the ColorOverlay extension in their pinned dz_node_palette.js',
182-
restore:
183-
'give the extensions distinct names and remove this entry when both packs load without a duplicate-registration error'
184-
}
185-
],
186173
'comfyui-sam3': [
187174
{
188175
id: 'sam3-editor-legacy-clipspace-import',

0 commit comments

Comments
 (0)