test: harden browser test readiness

Author: benjcooley

browser_tests/tests/sidebar/assets.spec.ts

@@ -1123,21 +1123,22 @@ test.describe('Assets sidebar - drag and drop', () => {
 
     await comfyPage.workflow.loadWorkflow('widgets/load_image_widget')
 
-    await comfyPage.canvas.focus()
-    await comfyPage.page.keyboard.press('.')
+    const [loadImage] = await comfyPage.nodeOps.getNodeRefsByType('LoadImage')
+    if (!loadImage) throw new Error('Load Image node not found')
+    await loadImage.centerOnNode()
+
     const { assetsTab } = comfyPage.menu
     await assetsTab.open()
     await assetsTab.waitForAssets()
     await expect(assetsTab.assetCards).toHaveCount(1)
 
     const targetPosition =
-      (await comfyPage.canvasOps.getNodeCenterByTitle('Load Image')) ??
-      undefined
+      await comfyPage.canvasOps.getNodeCenterByTitle('Load Image')
+    if (!targetPosition) throw new Error('Load Image node center not found')
 
     await assetsTab.assetCards.dragTo(comfyPage.canvas, { targetPosition })
 
-    const nodes = await comfyPage.nodeOps.getNodeRefsByType('LoadImage')
-    const fileComboWidget = await nodes[0].getWidget(0)
+    const fileComboWidget = await loadImage.getWidget(0)
     await expect.poll(() => fileComboWidget.getValue()).toBe('test.png [temp]')
   })
 

browser_tests/tests/sidebar/modelLibraryAssetMode.spec.ts

@@ -1,7 +1,10 @@
 import { expect, mergeTests } from '@playwright/test'
 
 import type { Asset } from '@comfyorg/ingest-types'
-import { assetApiFixture } from '@e2e/fixtures/assetApiFixture'
+import {
+  assetApiFixture,
+  assetRequestIncludesTag
+} from '@e2e/fixtures/assetApiFixture'
 import { comfyPageFixture } from '@e2e/fixtures/ComfyPage'
 import {
   MODEL_TYPE_CHECKPOINT_GGUF,
@@ -63,7 +66,16 @@ test.describe('Model library sidebar - asset mode', () => {
     await comfyPage.featureFlags.setServerFlagsPersistent({
       supports_model_type_tags: true
     })
+    const modelWalkResponse = comfyPage.page.waitForResponse(
+      (response) =>
+        response.request().method() === 'GET' &&
+        assetRequestIncludesTag(response.url(), 'models')
+    )
     await comfyPage.menu.modelLibraryTab.open()
+    await modelWalkResponse
+    await expect(
+      comfyPage.menu.modelLibraryTab.modelTree.locator('.pi-spinner')
+    ).toHaveCount(0)
   })
 
   test('Lists folders in backend registration order', async ({ comfyPage }) => {

browser_tests/tests/vueNodes/layout/rendererToggleGeometry.spec.ts

@@ -9,6 +9,8 @@ test.describe('Renderer toggle geometry', { tag: ['@vue-nodes'] }, () => {
   test('slot geometry survives a Vue to legacy round trip', async ({
     comfyPage
   }) => {
+    await comfyPage.workflow.loadWorkflow('default')
+
     const nodeId = toNodeId(
       await comfyPage.vueNodes.getNodeIdByTitle('KSampler')
     )