Sweep the 'subscription' settings-panel leftovers and orphaned SubscriptionPanel components

[christian-byrne]

Residual from the review of #14613. Non-blocking, cleanup.

#14613 correctly deleted subscriptionPanel, shouldShowPlanCreditsPanel and shouldShowLegacyPlanCreditsPanel from useSettingUI.ts once they became unreachable. Three leftovers were not swept:

1. src/platform/settings/types.ts:87 still lists | 'subscription' in SettingPanelType, and src/platform/settings/composables/useSettingUI.ts:36 still carries subscription: 'icon-[lucide--credit-card]' in CATEGORY_ICONS. No panel can now produce that key.
2. SubscriptionPanel.vue and SubscriptionPanelContentLegacy.vue are now reachable only from SubscriptionPanel.test.ts and SubscriptionPanelContentLegacy.test.ts. The test imports keep knip quiet while the components have no production entry point, so knip will not flag them as dead.
3. src/platform/settings/composables/useSettingUI.test.ts:303-312 still parameterises over billingType with it.for(['legacy', 'workspace']), which the composable no longer reads. Both cases are now byte-identical and the not.toContain('subscription') assertion passes vacuously.

Thread: #14613 (comment)

[coderabbitai]

🔗 Related PRs

#14050 - Fix Team Workspace seat capacity handling (FE-1497) [open]
#14242 - fix(billing): support subscription 3DS verification (FE-1436) [merged]
#14483 - feat(billing): consolidate embedded checkout frontend [open]
#14530 - feat: retire team workspace rollout flags [open]
#14602 - fix: align profile billing action with distribution [open]

---

🧪 Issue enrichment is currently in open beta.

You can configure auto-planning by selecting labels in the issue_enrichment configuration.

To disable automatic issue enrichment, add the following to your .coderabbit.yaml:

issue_enrichment:
  auto_enrich:
    enabled: false

💬 Have feedback or questions? Drop into our discord!

[christian-byrne]

Narrowing after #14613 merged. The useSettingUI.ts half is done: subscriptionPanel, shouldShowPlanCreditsPanel and shouldShowLegacyPlanCreditsPanel are all gone from main, and Cloud keeps a reachable Plan and Credits surface via planCreditsPanel.

Two leftovers remain on main, both small:

1. src/platform/settings/types.ts still lists | 'subscription' in SettingPanelType, and src/platform/settings/composables/useSettingUI.ts still carries subscription: 'icon-[lucide--credit-card]' in CATEGORY_ICONS. No panel can produce that key any more.
2. SubscriptionPanel.vue and SubscriptionPanelContentLegacy.vue are reachable only from their own tests, so knip reports them as live while they have no production entry point.

Neither is urgent; both are the kind of thing that quietly misleads the next person reading the settings registry.

[dante01yoon]

Verified against current main. The reported leftovers are valid, with one scope addition: two production callers still pass the removed subscription settings-panel key:

• CurrentUserPopoverLegacy.vue uses it for Cloud plan management.
• TopUpCreditsDialogContentLegacy.vue uses it after a successful legacy subscription credit purchase.

Because useSettingUI no longer exposes a subscription panel, these calls currently fall back to the first regular settings category. Removing the key from SettingPanelType without migrating them would also fail typecheck.

Plan:

1. Route both stale callers to the canonical Cloud workspace / Plan & Credits surface and update their component tests.
2. Remove subscription from SettingPanelType and CATEGORY_ICONS.
3. Delete the orphaned SubscriptionPanel.vue and SubscriptionPanelContentLegacy.vue components and their tests.
4. Replace the billing-type-parameterized useSettingUI test with one Cloud navigation test, removing the unused billing-context mock/state.
5. Remove or revise remaining comments that describe SubscriptionPanel as a reachable UI choice.
6. Validate with focused Vitest coverage, pnpm typecheck, lint/format checks, pnpm knip, and a repository search confirming no settings-panel or component references remain while preserving unrelated billing-domain uses of subscription.