Skip to content

Consolidate multi-select modifier detection #15028

Description

@ryan-di

Summary

Move the shared Ctrl/Cmd/Shift selection-modifier check to a neutral utility and use it across asset and Vue node selection paths.

Why

PR #14765 exposed duplicate event.shiftKey || event.metaKey || event.ctrlKey checks in MediaAssetCard and MediaVideoTop. Those checks need to remain exact complements; if they drift, the same click could both play a video and select the asset.

An existing isMultiSelectKey() helper lives under renderer/extensions/vueNodes, which is not an appropriate dependency for asset components.

Scope

  • Choose a neutral shared location for isMultiSelectKey().
  • Migrate Vue node selection consumers.
  • Migrate MediaAssetCard and MediaVideoTop.
  • Migrate the equivalent check in useAssetGridSelection.
  • Add focused tests that keep modifier behavior aligned.

References

Metadata

Metadata

Assignees

No one assigned

    Labels

    area:uiGeneral user interface and experience improvements

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions