docs: clarify ECS node IDs are sequential integers, not UUIDs - #15712
Closed
christian-byrne wants to merge 1 commit into
Closed
docs: clarify ECS node IDs are sequential integers, not UUIDs#15712christian-byrne wants to merge 1 commit into
christian-byrne wants to merge 1 commit into
Conversation
dosubot
Bot
added
the
size:S
Contributor
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 42 minutes Limit details: You’ve used the included review currently available. Your 91 included PR review attempts over the past 7 days set your current allowance at 1 review per hour. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?Wait for the limit to reset, then comment An organization admin can change what happens after included review limits in Billing. How do review limits work?CodeRabbit enforces per-developer PR review limits within each organization. For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (6)
Comment |
🎭 Playwright: ✅ 1983 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 9.11 MB gzip 🟢 -21 BDetailsSummary
Category Glance App Entry Points — 3.71 kB (baseline 3.71 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.38 MB (baseline 1.38 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 13 added / 13 removed / 4 unchanged Panels & Settings — 591 kB (baseline 591 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 11 added / 11 removed / 16 unchanged User & Accounts — 27.5 kB (baseline 27.5 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 125 kB (baseline 125 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 67.1 kB (baseline 67.1 kB) • ⚪ 0 BReusable component library chunks
Status: 6 added / 6 removed / 8 unchanged Data & Services — 3.53 MB (baseline 3.53 MB) • 🔴 +95 BStores, services, APIs, and repositories
Status: 14 added / 14 removed / 3 unchanged Utilities & Hooks — 549 kB (baseline 549 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 18 added / 18 removed / 19 unchanged Vendor & Third-Party — 18.1 MB (baseline 18.1 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 14.1 MB (baseline 14.1 MB) • ⚪ 0 BBundles that do not match a named category
Status: 66 added / 66 removed / 219 unchanged ⚡ Performance
|
github-actions
Bot
added
the
risk:R2
The NodeLocatorId format for subgraph nodes is <subgraph-definition-uuid>:<local-node-id> where the subgraph UUID identifies the definition, and the node ID is a sequential integer. Several comments, test descriptions, and architecture docs used ambiguous 'UUID format' or 'subgraphId' terminology that could lead readers to assume node IDs themselves are UUIDs.
christian-byrne
force-pushed
the
docs/FE-1814-ecs-node-ids-not-uuids
branch
from
August 23, 2026 07:27
fe54ab3 to
74db372
Compare
christian-byrne
enabled auto-merge
August 23, 2026 07:31
auto-merge was automatically disabled
August 23, 2026 07:31
Pull request was closed
Contributor
Author
|
Re-opening — CI was green and this is a docs-only fix for FE-1814 (clarifying that ECS NodeIds are sequential integers, not UUIDs). If there's a reason this should be closed or target a different branch, please let me know. |
Contributor
Author
|
Hi @christian-byrne — could you let me know why this was closed? CI was green and the change is docs-only (clarifying that ECS NodeIds are sequential integers, not UUIDs, per Linear issue FE-1814). Happy to adjust if the approach needs changing. |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #15712 +/- ##
==========================================
+ Coverage 79.42% 81.90% +2.47%
==========================================
Files 2218 1888 -330
Lines 112288 107296 -4992
Branches 31273 30087 -1186
==========================================
- Hits 89185 87877 -1308
+ Misses 22624 19072 -3552
+ Partials 479 347 -132
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 344 files with indirect coverage changes 🚀 New features to boost your workflow:
|
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
graphTraversalUtil.tsJSDoc — theNodeLocatorIdformat is<subgraph-definition-uuid>:<node-id>where the node ID is a sequential integer, not a UUIDgraphTraversalUtil.test.tsandnodeIdentification.test.tsto accurately describe what's being testedecs-target-architecture.md,ecs-migration-plan.md,proto-ecs-stores.md) to usesubgraphUUIDinstead of ambiguoussubgraphIdin key format descriptionsFixes FE-1814: ECS node IDs are not UUIDs — correct the docs that assume they are and the code that assumes they are.
Test plan
nodeIdentification.test.tsandgraphTraversalUtil.test.tspass🤖 Generated with Claude Code