-
Notifications
You must be signed in to change notification settings - Fork 9
Open
Labels
Description
Implementation rules and drivers
⚙️ Supported versions
- Repository should support only PHP
^8.0version - At the beginning, the supported Sylius versions are
^1.10(so 3 minor versions that should be properly tested in the CI). In the future we shall move to^1.12support only
📝 Testing
- All crucial paths of the payment flow (happy path, canceled payment, failed payment etc.) shall be covered with the Behat scenarios
- To avoid calling the test API in them, we would use Mockoon tool, to mock the responses in the CI
- All essential API calls to the Saferpay API should be covered with contract tests that would be run once a day (to not call the real API too often, but to be aware of any changes in the API contract)
- All classes with any behavior should be covered with PHPSpec tests
💻 DX and debugging
- All the new configurations should use
phpfiles rather thanyaml. All the existing configurations shall be migrated tophp. - All the important information about the payment flow (both success and failure) should be logged in the dedicated log panel. Errors should also be logged in the separated
saferpay.logfile
Reactions are currently unavailable