Improve Analyzer Performance

Author: TheCodeTraveler

src/CommunityToolkit.Maui.Analyzers/MaximumRatingRangeAnalyzer.cs

@@ -1,11 +1,11 @@
-namespace CommunityToolkit.Maui.Analyzers;
-
-using System.Collections.Immutable;
+using System.Collections.Immutable;
 using Microsoft.CodeAnalysis;
 using Microsoft.CodeAnalysis.CSharp;
 using Microsoft.CodeAnalysis.CSharp.Syntax;
 using Microsoft.CodeAnalysis.Diagnostics;
 
+namespace CommunityToolkit.Maui.Analyzers;
+
 [DiagnosticAnalyzer(LanguageNames.CSharp)]
 public class MaximumRatingRangeAnalyzer : DiagnosticAnalyzer
 {
@@ -38,28 +38,16 @@ public override void Initialize(AnalysisContext context)
 
 	static void AnalyzePropertyAssignment(SyntaxNodeAnalysisContext context)
 	{
-		AssignmentExpressionSyntax assignmentExpression = (AssignmentExpressionSyntax)context.Node;
-		if (assignmentExpression.Left is IdentifierNameSyntax leftIdentifier && leftIdentifier.Identifier.Text == "MaximumRating")
+		if (context.Node is AssignmentExpressionSyntax { Left: IdentifierNameSyntax { Identifier.Text: "MaximumRating" } leftIdentifier, Right: LiteralExpressionSyntax { Token.Value: int value } } assignmentExpression)
 		{
-			SemanticModel semanticModel = context.SemanticModel;
-			IPropertySymbol? propertySymbol = semanticModel.GetSymbolInfo(leftIdentifier).Symbol as IPropertySymbol;
-			if (propertySymbol?.ContainingType.Name == "RatingView" && assignmentExpression.Right is LiteralExpressionSyntax literal && literal.IsKind(SyntaxKind.NumericLiteralExpression) && literal.Token.Value is not null)
-			{
-				int value = (int)literal.Token.Value;
+			var semanticModel = context.SemanticModel;
+			var propertySymbol = semanticModel.GetSymbolInfo(leftIdentifier).Symbol as IPropertySymbol;
 
-				// Validate the value is within the range
-				if (value is < minValue or > maxValue)
-				{
-					Diagnostic diagnostic = Diagnostic.Create(
-						rule,
-						assignmentExpression.GetLocation(),
-						minValue,
-						maxValue
-					);
-
-					context.ReportDiagnostic(diagnostic);
-				}
+			if (propertySymbol?.ContainingType.Name == "RatingView" && (value < minValue || value > maxValue))
+			{
+				var diagnostic = Diagnostic.Create(rule, assignmentExpression.GetLocation(), minValue, maxValue);
+				context.ReportDiagnostic(diagnostic);
 			}
 		}
 	}
-}
+}