Merge branch 'main' into FixResourceMediaSource

Author: ne0rrmatrix

.github/copilot-instructions.md

@@ -2,12 +2,12 @@
 This document provides guidelines for using GitHub Copilot to contribute to the .NET MAUI Community Toolkit. It includes instructions on setting up your environment, writing code, and following best practices specific to .NET MAUI.
 
 ## Prerequisites
-1.	Install the latest stable (.NET SDK)[https://dotnet.microsoft.com/en-us/download].
+1.	Install the latest stable [.NET SDK](https://dotnet.microsoft.com/en-us/download).
 2.	Install .NET MAUI workloads (we recommend using Visual Studio installer).
 
 ## Setting Up GitHub Copilot
 1.	Ensure you have GitHub Copilot installed and enabled in Visual Studio.
-2.	Familiarize yourself with the basic usage of GitHub Copilot by reviewing the (official documentation)[https://docs.github.com/en/copilot].
+2.	Familiarize yourself with the basic usage of GitHub Copilot by reviewing the [official documentation](https://docs.github.com/en/copilot).
 
 ## Writing Code with GitHub Copilot
 ### General Guidelines
@@ -17,15 +17,15 @@ This document provides guidelines for using GitHub Copilot to contribute to the
 ### Specific to .NET MAUI
 * Ensure that any UI components or controls are compatible with .NET MAUI.
 * Avoid using Xamarin.Forms-specific code unless there is a direct .NET MAUI equivalent.
-* Follow the project's coding style and best practices as outlined in the (contributing)[https://github.com/CommunityToolkit/Maui/blob/main/CONTRIBUTING.md] document.
+* Follow the project's coding style and best practices as outlined in the [contributing](https://github.com/CommunityToolkit/Maui/blob/main/CONTRIBUTING.md) document.
 
 ## Best Practices
 * Use **Trace.WriteLine()** for debug logging instead of **Debug.WriteLine()**.
 * Include a **CancellationToken** as a parameter for methods returning **Task** or **ValueTask**.
 * Use **is** for null checking and type checking.
 * Use file-scoped namespaces to reduce code verbosity.
 * Avoid using the **!** null forgiving operator.
-** Follow naming conventions for enums and property names.
+* Follow naming conventions for enums and property names.
 
 ### Debug Logging
 * Always use `Trace.WriteLine()` instead of `Debug.WriteLine` for debug logging because `Debug.WriteLine` is removed by the compiler in Release builds
@@ -141,7 +141,7 @@ Read and follow our [Pull Request template](https://github.com/CommunityToolkit/
 4.	Open a pull request and follow the [Pull Request template](https://github.com/CommunityToolkit/Maui/blob/main/.github/PULL_REQUEST_TEMPLATE.md).
 
 ## Additional Resources
-- (GitHub Copilot Documentation)[https://docs.github.com/en/copilot]
-- (.NET MAUI Documentation)[https://learn.microsoft.com/en-us/dotnet/maui/]
+* [GitHub Copilot Documentation](https://docs.github.com/en/copilot)
+* [.NET MAUI Documentation](https://learn.microsoft.com/en-us/dotnet/maui/)
 
-By following these guidelines, you can effectively use GitHub Copilot to contribute to the .NET MAUI Community Toolkit. Thank you for your contributions!
+By following these guidelines, you can effectively use GitHub Copilot to contribute to the .NET MAUI Community Toolkit. Thank you for your contributions!

Directory.Build.props

@@ -173,7 +173,8 @@
      XC0618: Property, Property setter or BindableProperty "BackgroundColor" is deprecated
      IL2***: Trim Warnings     
      IL3***: AOT Warnings     
-     RS2007: Analyzer release file 'AnalyzerReleases.Shipped.md' has a missing or invalid release header-->
+     RS1038: Compiler extensions should be implemented in assemblies with compiler-provided references
+     RS2007: Analyzer release file 'AnalyzerReleases.Shipped.md' has a missing or invalid release header -->
     <WarningsAsErrors>
       nullable,
       CS0419,CS1570,CS1571,CS1572,CS1573,CS1574,CS1580,CS1581,CS1584,CS1587,CS1589,CS1590,CS1591,CS1592,CS1598,CS1658,CS1710,CS1711,CS1712,CS1723,CS1734,
@@ -198,7 +199,7 @@
       IL2110,IL2111,IL2112,IL2113,IL2114,IL2115,IL2116,IL2117,IL2118,IL2119,
       IL2120,IL2121,IL2122,
       IL3050,IL3051,IL3052,IL3053,IL3054,IL3055,IL3056,
-      RS2007
+      RS1038,RS2007
     </WarningsAsErrors>
 
     <!--

samples/CommunityToolkit.Maui.Sample/Pages/Views/MediaElement/MediaElementPage.xaml.cs

@@ -253,7 +253,7 @@ async void DisplayPopup(object sender, EventArgs e)
 			ShouldAutoPlay = true,
 			ShouldShowPlaybackControls = true,
 		};
-    
+
 		await this.ShowPopupAsync(popupMediaElement);
 		popupMediaElement.Stop();
 	}

samples/CommunityToolkit.Maui.Sample/Pages/Views/Popup/PopupsPage.xaml.cs

@@ -125,9 +125,9 @@ async void HandleSelfClosingPopupButtonClicked(object? sender, EventArgs e)
 		{
 			CanBeDismissedByTappingOutsideOfPopup = false
 		});
-		
+
 		await Task.Delay(TimeSpan.FromSeconds(2));
-		
+
 		await this.ClosePopupAsync();
 	}
 }

src/CommunityToolkit.Maui.Analyzers/CommunityToolkit.Maui.Analyzers.csproj

@@ -13,7 +13,7 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.14.0" PrivateAssets="all" />
+    <PackageReference Include="Microsoft.CodeAnalysis.CSharp" Version="4.14.0" PrivateAssets="all" />
   </ItemGroup>
 
   <ItemGroup>

src/CommunityToolkit.Maui.Camera.Analyzers/CommunityToolkit.Maui.Camera.Analyzers.csproj

@@ -13,7 +13,7 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.14.0" PrivateAssets="all" />
+    <PackageReference Include="Microsoft.CodeAnalysis.CSharp" Version="4.14.0" PrivateAssets="all" />
   </ItemGroup>
 
   <ItemGroup>

src/CommunityToolkit.Maui.MediaElement.Analyzers/CommunityToolkit.Maui.MediaElement.Analyzers.csproj

@@ -13,7 +13,7 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.14.0" PrivateAssets="all" />
+    <PackageReference Include="Microsoft.CodeAnalysis.CSharp" Version="4.14.0" PrivateAssets="all" />
   </ItemGroup>
 
   <ItemGroup>

src/CommunityToolkit.Maui.MediaElement/Views/MauiMediaElement.android.cs

@@ -180,7 +180,6 @@ void SetSystemBarsVisibility()
 		}
 		else
 		{
-			WindowCompat.SetDecorFitsSystemWindows(currentWindow, true);
 			if (OperatingSystem.IsAndroidVersionAtLeast(30))
 			{
 				if (isSystemBarVisible)
@@ -195,6 +194,7 @@ void SetSystemBarsVisibility()
 
 			windowInsetsControllerCompat.Show(barTypes);
 			windowInsetsControllerCompat.SystemBarsBehavior = WindowInsetsControllerCompat.BehaviorDefault;
+			WindowCompat.SetDecorFitsSystemWindows(currentWindow, true);
 		}
 	}
 

src/CommunityToolkit.Maui.MediaElement/Views/MauiMediaElement.macios.cs

@@ -170,7 +170,7 @@ static bool TryGetCurrentPage([NotNullWhen(true)] out Page? currentPage)
 		}
 
 		// If not using Shell or a Modal Page, return the visible page in the (non-modal) NavigationStack
-		if (window.Navigation.NavigationStack[^1] is Page page)
+		if (window.Navigation.NavigationStack.LastOrDefault() is Page page)
 		{
 			currentPage = page;
 			return true;

src/CommunityToolkit.Maui.SourceGenerators.Internal/CommunityToolkit.Maui.SourceGenerators.Internal.csproj

@@ -15,7 +15,7 @@
   </ItemGroup>
 
   <ItemGroup>
-    <PackageReference Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.14.0" PrivateAssets="all" />
+    <PackageReference Include="Microsoft.CodeAnalysis.CSharp" Version="4.14.0" PrivateAssets="all" />
   </ItemGroup>
 
 </Project>