Skip to content

Commit 760c451

Browse files
authored
Merge branch 'main' into feature/rangeslider
2 parents d4db602 + 44d9173 commit 760c451

File tree

79 files changed

+1677
-1194
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

79 files changed

+1677
-1194
lines changed

.github/workflows/benchmarks.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ jobs:
5656
run: dotnet run --project ${{ env.PathToCommunityToolkitSourceGeneratorsBenchmarksCsproj }} -c Release -- -a "${{ runner.temp }}"
5757

5858
- name: Publish Benchmarks
59-
uses: actions/upload-artifact@v5
59+
uses: actions/upload-artifact@v6
6060
with:
6161
name: Benchmarks
6262
path: |

.github/workflows/dotnet-build.yml

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@ env:
4646
PathToCommunityToolkitSourceGeneratorsInternalUnitTestCsproj: 'src/CommunityToolkit.Maui.SourceGenerators.Internal.UnitTests/CommunityToolkit.Maui.SourceGenerators.Internal.UnitTests.csproj'
4747
PathToCommunityToolkitAnalyzersBenchmarkCsproj: 'src/CommunityToolkit.Maui.Analyzers.Benchmarks/CommunityToolkit.Maui.Analyzers.Benchmarks.csproj'
4848
CommunityToolkitLibrary_Xcode_Version: '26.1'
49+
CommunityToolkitSample_Xcode_Version: '26.2'
4950

5051
concurrency:
5152
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
@@ -67,7 +68,7 @@ jobs:
6768
if: runner.os == 'macOS'
6869
uses: maxim-lobanov/setup-xcode@v1
6970
with:
70-
xcode-version: ${{ env.CommunityToolkitLibrary_Xcode_Version }}
71+
xcode-version: ${{ env.CommunityToolkitSample_Xcode_Version }}
7172

7273
- name: Install Latest .NET SDK, v${{ env.LATEST_NET_VERSION }}
7374
uses: actions/setup-dotnet@v5
@@ -254,7 +255,7 @@ jobs:
254255
shell: pwsh
255256

256257
- name: Upload Package List
257-
uses: actions/upload-artifact@v5
258+
uses: actions/upload-artifact@v6
258259
if: ${{ runner.os == 'Windows' }}
259260
with:
260261
name: nuget-list
@@ -264,7 +265,7 @@ jobs:
264265
265266
- name: Publish Packages
266267
if: ${{ runner.os == 'Windows' }}
267-
uses: actions/upload-artifact@v5
268+
uses: actions/upload-artifact@v6
268269
with:
269270
name: packages
270271
path: ${{ github.workspace }}/nuget/
@@ -284,13 +285,13 @@ jobs:
284285
dotnet-quality: 'ga'
285286

286287
- name: Download NuGet List
287-
uses: actions/download-artifact@v6
288+
uses: actions/download-artifact@v7
288289
with:
289290
name: nuget-list
290291
path: ./
291292

292293
- name: Download Package List
293-
uses: actions/download-artifact@v6
294+
uses: actions/download-artifact@v7
294295
with:
295296
name: packages
296297
path: ./packages
@@ -336,7 +337,7 @@ jobs:
336337
--verbosity Information
337338
338339
- name: Publish Packages
339-
uses: actions/upload-artifact@v5
340+
uses: actions/upload-artifact@v6
340341
with:
341342
name: signed-packages
342343
if-no-files-found: error
@@ -356,7 +357,7 @@ jobs:
356357
dotnet-quality: 'ga'
357358

358359
- name: Download signed packages
359-
uses: actions/download-artifact@v6
360+
uses: actions/download-artifact@v7
360361
with:
361362
name: signed-packages
362363
path: ./packages
@@ -384,7 +385,7 @@ jobs:
384385
dotnet-quality: 'ga'
385386

386387
- name: Download signed packages
387-
uses: actions/download-artifact@v6
388+
uses: actions/download-artifact@v7
388389
with:
389390
name: signed-packages
390391
path: ./packages

.github/workflows/dotnet-format-daily.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ jobs:
3131
git commit -a -m 'Automated dotnet-format update'
3232
3333
- name: Create Pull Request
34-
uses: peter-evans/create-pull-request@v7
34+
uses: peter-evans/create-pull-request@v8
3535
with:
3636
title: '[housekeeping] Automated PR to fix formatting errors'
3737
body: |

Directory.Build.props

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ https://docs.microsoft.com/en-us/windows/win32/fileio/maximum-file-path-limitati
2222
<NuGetAuditMode>all</NuGetAuditMode>
2323

2424
<!-- MAUI Specific -->
25-
<MauiPackageVersion>10.0.10</MauiPackageVersion>
25+
<MauiPackageVersion>10.0.20</MauiPackageVersion>
2626
<MauiStrictXamlCompilation>true</MauiStrictXamlCompilation>
2727
<SkipValidateMauiImplicitPackageReferences>true</SkipValidateMauiImplicitPackageReferences>
2828
<MauiEnableXamlCBindingWithSourceCompilation>true</MauiEnableXamlCBindingWithSourceCompilation>

samples/CommunityToolkit.Maui.Sample/CommunityToolkit.Maui.Sample.csproj

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,8 +57,8 @@
5757
<PackageReference Include="Microsoft.Maui.Controls" Version="*" />
5858
<PackageReference Include="CommunityToolkit.Maui.Markup" Version="7.0.0" />
5959
<PackageReference Include="CommunityToolkit.Mvvm" Version="8.4.0" />
60-
<PackageReference Include="Microsoft.Extensions.Http.Resilience" Version="10.0.0" />
61-
<PackageReference Include="Microsoft.Extensions.Logging.Debug" Version="10.0.0" />
60+
<PackageReference Include="Microsoft.Extensions.Http.Resilience" Version="10.1.0" />
61+
<PackageReference Include="Microsoft.Extensions.Logging.Debug" Version="10.0.1" />
6262
</ItemGroup>
6363

6464
<PropertyGroup>

samples/CommunityToolkit.Maui.Sample/MauiProgram.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -270,6 +270,7 @@ static void RegisterViewsAndViewModels(in IServiceCollection services)
270270
// Add Popups
271271
services.AddTransientPopup<ApplyToDerivedTypesPopup>();
272272
services.AddTransientPopup<ButtonPopup>();
273+
services.AddTransientPopup<CollectionViewPopup, CollectionViewPopupViewModel>();
273274
services.AddTransientPopup<ComplexPopup, ComplexPopupViewModel>();
274275
services.AddTransientPopup<CsharpBindingPopup, CsharpBindingPopupViewModel>();
275276
services.AddTransientPopup<DynamicStyleInheritancePopup>();

samples/CommunityToolkit.Maui.Sample/Pages/Views/Popup/PopupsPage.xaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,8 @@
5252

5353
<Button Text="Complex Popup" Clicked="HandleComplexPopupClicked" />
5454

55+
<Button Text="Collection View Popup" Clicked="HandleCollectionViewPopupClicked" />
56+
5557
</VerticalStackLayout>
5658
</ScrollView>
5759
</ContentPage.Content>

samples/CommunityToolkit.Maui.Sample/Pages/Views/Popup/PopupsPage.xaml.cs

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -150,6 +150,20 @@ async void HandleSelfClosingPopupButtonClicked(object? sender, EventArgs e)
150150
await this.ClosePopupAsync();
151151
}
152152

153+
async void HandleCollectionViewPopupClicked(object? sender, EventArgs e)
154+
{
155+
var popupResult = await popupService.ShowPopupAsync<CollectionViewPopup, string>(
156+
Navigation,
157+
PopupOptions.Empty,
158+
CancellationToken.None);
159+
160+
if (!popupResult.WasDismissedByTappingOutsideOfPopup)
161+
{
162+
// Display Popup Result as a Toast
163+
await Toast.Make($"You selected {popupResult.Result}").Show(CancellationToken.None);
164+
}
165+
}
166+
153167
async void HandleComplexPopupClicked(object? sender, EventArgs e)
154168
{
155169
var complexPopupOpenedCancellationTokenSource = new CancellationTokenSource();

samples/CommunityToolkit.Maui.Sample/Resources/Styles/Styles.xaml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,11 @@
2828
<Style TargetType="VerticalStackLayout" ApplyToDerivedTypes="true">
2929
<Setter Property="Spacing" Value="0" />
3030
</Style>
31+
32+
<!-- Highlights that this style will not be inherited by a popup -->
33+
<Style TargetType="BoxView" ApplyToDerivedTypes="True">
34+
<Setter Property="BackgroundColor" Value="Yellow" />
35+
</Style>
3136

3237
<Style TargetType="Button">
3338
<Setter Property="BackgroundColor" Value="{StaticResource NormalButtonBackgroundColor}" />

samples/CommunityToolkit.Maui.Sample/ViewModels/Essentials/FileSaverViewModel.cs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -88,9 +88,6 @@ async Task SaveFileInstance(CancellationToken cancellationToken)
8888
fileSaverResult.EnsureSuccess();
8989

9090
await Toast.Make($"File is saved: {fileSaverResult.FilePath}").Show(cancellationToken);
91-
#if IOS || MACCATALYST
92-
fileSaverInstance.Dispose();
93-
#endif
9491
}
9592
catch (Exception ex)
9693
{

0 commit comments

Comments
 (0)