Refactorings based on code review suggestions

Author: bijington

src/CommunityToolkit.Maui.UnitTests/Mocks/MockDispatcher.cs

@@ -22,12 +22,9 @@ public bool Dispatch(Action action)
 
 	public bool DispatchDelayed(TimeSpan delay, Action action)
 	{
-		Task.Run(async () =>
-		{
-			await Task.Delay(delay);
-		
-			action();
-		});
+		Thread.Sleep(delay);
+
+		action();
 
 		return true;
 	}

src/CommunityToolkit.Maui.UnitTests/Services/PopupServiceTests.cs

@@ -561,31 +561,31 @@ void HandlePopupClosed(object? sender, EventArgs e)
 		cancellationTokenSource?.Cancel();
 	}
 
-	void HandlePopupOpened(object? sender, EventArgs e)
+	async void HandlePopupOpened(object? sender, EventArgs e)
 	{
-		cancellationTokenSource?.Cancel();
-		
+		if (cancellationTokenSource is not null)
+		{
+			await cancellationTokenSource.CancelAsync();
+		}
+
 		cancellationTokenSource = new CancellationTokenSource();
-		
+
 		Console.WriteLine($"{DateTime.Now:O} HandlePopupOpened {BindingContext.GetType().Name}");
 
-		Dispatcher.DispatchDelayed(
-			DisplayDuration,
-			async () =>
-			{
-				if (cancellationTokenSource?.IsCancellationRequested is true)
-				{
-					return;
-				}
-				
-				Console.WriteLine(
-					$"{DateTime.Now:O} Closing {BindingContext.GetType().Name} - {Application.Current?.Windows[0].Page?.Navigation.ModalStack.Count}");
-				
-				await CloseAsync(Result, cancellationTokenSource?.Token ?? CancellationToken.None);
-
-				Console.WriteLine(
-					$"{DateTime.Now:O} Closed {BindingContext.GetType().Name} - {Application.Current?.Windows[0].Page?.Navigation.ModalStack.Count}");
-			});
+		await Task.Delay(DisplayDuration);
+
+		if (cancellationTokenSource?.IsCancellationRequested is true)
+		{
+			return;
+		}
+
+		Console.WriteLine(
+			$"{DateTime.Now:O} Closing {BindingContext.GetType().Name} - {Application.Current?.Windows[0].Page?.Navigation.ModalStack.Count}");
+
+		await CloseAsync(Result, cancellationTokenSource?.Token ?? CancellationToken.None);
+
+		Console.WriteLine(
+			$"{DateTime.Now:O} Closed {BindingContext.GetType().Name} - {Application.Current?.Windows[0].Page?.Navigation.ModalStack.Count}");
 	}
 
 	public object? Result { get; }