You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: CONTRIBUTING.md
+5-5Lines changed: 5 additions & 5 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -20,7 +20,7 @@ During a code review try to make a habit out of it to say at least one nice thin
20
20
21
21
### Make an effort to see it from their perspective
22
22
23
-
Remember English is not everyones native language. Written communication always lacks non-verbal communication. With written communication in a language that is not your native tongue it is even harder to express certain emotions.
23
+
Remember English is not everyone's native language. Written communication always lacks non-verbal communication. With written communication in a language that is not your native tongue it is even harder to express certain emotions.
24
24
25
25
Always assume that people mean to do right. Try to read a sentence a couple of times over and take things more literal. Try to place yourself in their shoes and see the message beyond the actual words.
26
26
@@ -55,7 +55,7 @@ If you found something that looks like a bug don't hesitate in opening an issue
55
55
56
56
### Bug reproduction
57
57
58
-
We always request a reproduction sample, and that's not to make your life hard or anything like that... The reason of having a reproduction is to save us time to indentify and fix the bug. Create a new project; download the MCT NuGet; write UI; ViewModel; create a service; run it. As you can see it's a lot of timing consuming for us that we could spend fixing the actual issue. So **PLEASE** create a small reproduction project, upload it on GitHub or GitLab and paste the link in the issue.
58
+
We always request a reproduction sample, and that's not to make your life hard or anything like that... The reason of having a reproduction is to save us time to identify and fix the bug. Create a new project; download the MCT NuGet; write UI; ViewModel; create a service; run it. As you can see it's a lot of timing consuming for us that we could spend fixing the actual issue. So **PLEASE** create a small reproduction project, upload it on GitHub or GitLab and paste the link in the issue.
59
59
60
60
> We don't accept `.zip` files as reproduction samples, for security reasons. So if you send us a `.zip` file we will kindly ask you to upload it to GitHub or GitLab and share the link
61
61
@@ -136,8 +136,8 @@ Here we will have some:
136
136
### Methods Returning Task and ValueTask
137
137
138
138
* Always include a `CancellationToken` as a parameter to every method returning `Task` or `ValueTask`
139
-
* If the method is public, provide a the default value for the `CancellationToken` (eg`CancellationToken token = default`)
140
-
* If the method is not publc, do not provide a default value for the `CancellationToken`
139
+
* If the method is public, provide the default value for the `CancellationToken` (e.g.`CancellationToken token = default`)
140
+
* If the method is not public, do not provide a default value for the `CancellationToken`
141
141
* Use `CancellationToken.ThrowIfCancellationRequested()` to verify the `CancellationToken`
142
142
143
143
### Enums
@@ -250,4 +250,4 @@ The following topics should generally not be proposed for discussion as they are
250
250
* Large renames of APIs
251
251
* Large non-backward-compatible breaking changes
252
252
* Platform-Specifics which can be accomplished without changing the .NET MAUI Community Toolkit
253
-
* Avoid clutter posts like "+1" which do not serve to further the conversation, please use the emoji resonses for that
253
+
* Avoid clutter posts like "+1" which do not serve to further the conversation, please use the emoji responses for that
Copy file name to clipboardExpand all lines: README.md
+1-1Lines changed: 1 addition & 1 deletion
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -80,7 +80,7 @@ Discussions that are short and stay on topic are much more likely to be read. If
80
80
- Is your comment useful for others to read, or can it be adequately expressed with an emoji reaction to an existing comment?
81
81
82
82
### 2. Proposal Submitted
83
-
Once you have a fully fleshed out proposal describing a new feature in syntactic and semantic detail, please [open an issue for it](https://github.com/communitytoolkit/maui/issues/new/choose), and it will be labeled as a [Proposal](https://github.com/communitytoolkit/maui/issues?q=is%3Aopen+is%3Aissue+label%3Aproposal). The comment thread on the issue can be used to hash out or briefly discuss details of the proposal, as well as pros and cons of adopting it into the .NET MAUI Toolkit. If an issue does not meet the bar of being a full proposal, we may move it to a discussion, so that it can be further matured. Specific open issues or more expansive discussion with a proposal will often warrant opening a side discussion rather than cluttering the comment section on the issue.
83
+
Once you have a fully fleshed out proposal describing a new feature in syntactic and semantic detail, please [open an issue for it](https://github.com/communitytoolkit/maui/issues/new/choose), and it will be labelled as a [Proposal](https://github.com/communitytoolkit/maui/issues?q=is%3Aopen+is%3Aissue+label%3Aproposal). The comment thread on the issue can be used to hash out or briefly discuss details of the proposal, as well as pros and cons of adopting it into the .NET MAUI Toolkit. If an issue does not meet the bar of being a full proposal, we may move it to a discussion, so that it can be further matured. Specific open issues or more expansive discussion with a proposal will often warrant opening a side discussion rather than cluttering the comment section on the issue.
84
84
85
85
### 3. Proposal Championed
86
86
When a member of the .NET MAUI Toolkit core team finds that a proposal merits promotion into the Toolkit, they can [Champion](https://github.com/communitytoolkit/maui/issues?q=is%3Aopen+is%3Aissue+label%3A%22proposal+champion%22) it, which means that they will bring it to the monthly [.NET MAUI Toolkit Community Standup](https://www.youtube.com/watch?v=0ZBh2Hl54ZY).
0 commit comments