Skip to content

Commit e13a633

Browse files
authored
Merge branch 'main' into AddSubtitleSupport
2 parents 08a6d76 + 5979390 commit e13a633

File tree

6 files changed

+9
-9
lines changed

6 files changed

+9
-9
lines changed

src/CommunityToolkit.Maui.Analyzers.UnitTests/CommunityToolkit.Maui.Analyzers.UnitTests.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.12.0" />
1818
<PackageReference Include="xunit" Version="2.9.3" />
1919
<PackageReference Include="xunit.runner.visualstudio" Version="3.0.1" PrivateAssets="All" />
20-
<PackageReference Include="coverlet.collector" Version="6.0.3" PrivateAssets="All" />
20+
<PackageReference Include="coverlet.collector" Version="6.0.4" PrivateAssets="All" />
2121
<PackageReference Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.12.0" />
2222
<PackageReference Include="Microsoft.Maui.Controls" Version="$(MauiPackageVersion)" />
2323
</ItemGroup>

src/CommunityToolkit.Maui.Camera/CameraManager.android.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,7 @@ protected virtual async partial Task PlatformConnectCamera(CancellationToken tok
172172

173173
protected async Task StartUseCase(CancellationToken token)
174174
{
175-
if (resolutionSelector is null)
175+
if (resolutionSelector is null || cameraExecutor is null)
176176
{
177177
return;
178178
}
@@ -183,7 +183,7 @@ protected async Task StartUseCase(CancellationToken token)
183183
imageCapture?.Dispose();
184184

185185
cameraPreview = new Preview.Builder().SetResolutionSelector(resolutionSelector).Build();
186-
cameraPreview.SetSurfaceProvider(previewView?.SurfaceProvider);
186+
cameraPreview.SetSurfaceProvider(cameraExecutor, previewView?.SurfaceProvider);
187187

188188
imageCapture = new ImageCapture.Builder()
189189
.SetCaptureMode(ImageCapture.CaptureModeMaximizeQuality)

src/CommunityToolkit.Maui.Camera/CommunityToolkit.Maui.Camera.csproj

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,8 @@
5151
</ItemGroup>
5252

5353
<ItemGroup Condition="$([MSBuild]::GetTargetPlatformIdentifier('$(TargetFramework)')) == 'android'">
54-
<PackageReference Include="Xamarin.AndroidX.Camera.Camera2" Version="1.3.1.1" />
55-
<PackageReference Include="Xamarin.AndroidX.Camera.View" Version="1.3.1.1" />
54+
<PackageReference Include="Xamarin.AndroidX.Camera.Camera2" Version="1.4.1" />
55+
<PackageReference Include="Xamarin.AndroidX.Camera.View" Version="1.4.1" />
5656

5757
<!-- Ensure Linker does not remove required libraries -->
5858
<None Include="linker.xml" Pack="true" PackagePath="build\$(PackageId).LinkerConfigurationFile.xml" />

src/CommunityToolkit.Maui.UnitTests/CommunityToolkit.Maui.UnitTests.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.12.0" />
1616
<PackageReference Include="xunit.v3" Version="1.0.1" />
1717
<PackageReference Include="xunit.runner.visualstudio" Version="3.0.1" PrivateAssets="All" />
18-
<PackageReference Include="coverlet.collector" Version="6.0.3" PrivateAssets="All" />
18+
<PackageReference Include="coverlet.collector" Version="6.0.4" PrivateAssets="All" />
1919
<PackageReference Include="Microsoft.Maui.Controls" Version="$(MauiPackageVersion)"/>
2020
</ItemGroup>
2121

src/CommunityToolkit.Maui/Converters/ICommunityToolkitValueConverter.shared.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,12 +52,12 @@ public interface ICommunityToolkitValueConverter : IValueConverter
5252

5353

5454
/// <inheritdoc />
55-
#pragma warning disable IL2092
55+
[UnconditionalSuppressMessage("TrimAnalysis", "IL2092", Justification = "The ToType and FromType properties are attributed with the appropriate DynamicallyAccessedMembers attributes.")]
5656
object? IValueConverter.Convert(object? value, [DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicParameterlessConstructor)] Type targetType, object? parameter, CultureInfo culture) =>
5757
Convert(value, targetType, parameter, culture);
5858

5959
/// <inheritdoc />
60+
[UnconditionalSuppressMessage("TrimAnalysis", "IL2092", Justification = "The ToType and FromType properties are attributed with the appropriate DynamicallyAccessedMembers attributes.")]
6061
object? IValueConverter.ConvertBack(object? value, [DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicParameterlessConstructor)] Type targetType, object? parameter, CultureInfo culture) =>
6162
ConvertBack(value, targetType, parameter, culture);
62-
#pragma warning restore IL2092
6363
}

src/CommunityToolkit.Maui/Extensions/AppThemeResourceExtension.shared.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
/// <summary>
44
/// A XAML markup extension that enables using <see cref="AppThemeColor"/> and <see cref="AppThemeObject"/> from XAML.
55
/// </summary>
6-
[ContentProperty(nameof(Key)), RequireService([typeof(IServiceProvider)])]
6+
[ContentProperty(nameof(Key)), RequireService([typeof(IServiceProvider), typeof(IProvideParentValues)])]
77
public sealed class AppThemeResourceExtension : IMarkupExtension<BindingBase>
88
{
99
/// <summary>

0 commit comments

Comments
 (0)