Add .vsconfig file #3575
Add .vsconfig file #3575
Conversation
|
Thanks RosarioPulella for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
ghost
requested review from
ghost
added
the
|
I might be able to trim this down more. I have to go through a cycle of uninstalling components and testing if everything works as expected. If there are any items that anyone knows of that either might not be needed or is not needed feel free to let me know and I will test it locally or test it yourself. |
| "Microsoft.NetCore.Component.Runtime.5.0", | ||
| "Microsoft.NetCore.Component.Runtime.3.1", |
There was a problem hiding this comment.
I think we need both of these runtimes, eh? @Sergio0694 @azchohfi
There was a problem hiding this comment.
Was playing around with trying to install and uninstall particular components...
The UWP Workload seems to require both those components.
There was a problem hiding this comment.
I was also playing around with creating a solution filter for the .NET Standard projects only, to make life easier for contributors that might only want to contribute to them (for instance, people that are on a Mac or on Linux). Would it make sense to do both things in this PR since it is about a closely related matter? Also about this, should we offer two separate .vsconfig files, one of which only targeting the cross platform .NET Standard toolset and without any Windows specific SDK needed? I think just the .NET SDK might be enough for them 🤔
There was a problem hiding this comment.
If we want to expand this pr it could also provide some value to connect this file into our CI system.
If we make it so that the build server only uses the VS comments from this file it could help in many ways.
- Makes it easy to add a VS component to the build system.
- Make it hard to add code to requires a VS component without listing it.
.vsconfig
Outdated
| "Microsoft.Net.Component.4.5.2.TargetingPack", | ||
| "Microsoft.Net.Component.4.5.TargetingPack", |
There was a problem hiding this comment.
Feel like we probably only need one of these. @azchohfi do you know which one we need now? Docs say 4.6.2 but that seems older?
There was a problem hiding this comment.
4.5 is required by the UWP workload and 4.5.2 is not, but 4.5.2 is recommended by the .Net desktop development workload.
From my local testing, it seems we don't need the .Net Desktop development Workload, only some components part of it.
As expected, it seems like the UWP Workload is required, for building and testing.
…o a bunch of not so needed packages.
Fixes #3547
Adds
.vsconfigfile. This is based on a fairly clean system that successfully builds and tests the solution through the build script.PR Type
What kind of change does this PR introduce?
What is the current behavior?
When opening the solution in Visual Studio there is no prompt to install missing build dependencies.
What is the new behavior?
Visual Studio now prompts users to install any missing dependencies when they open the solution in visual studio.
PR Checklist
Please check if your PR fulfills the following requirements: