Some 1903 APIs not Guarded

[michael-hawker]

Describe the bug

There are a few instances where we're exposing XamlRoot and UIContext in parameters to methods which won't work on our min version of 1809 as those APIs were introduced in 1903. We need to ensure we have a way to call these on 1809 still.

For instance:

• SystemInformation.TrackAppUse:

WindowsCommunityToolkit/Microsoft.Toolkit.Uwp/Helpers/SystemInformation.cs

Line 258 in 83a5bce

public void TrackAppUse(IActivatedEventArgs args, XamlRoot xamlRoot = null)

@azchohfi ideas on how we can encapsulate this better?

• StringExtensions.GetLocalized:

WindowsCommunityToolkit/Microsoft.Toolkit.Uwp/Extensions/StringExtensions.cs

Line 36 in 83a5bce

public static string GetViewLocalized(this string resourceKey, UIContext uiContext = null)

WindowsCommunityToolkit/Microsoft.Toolkit.Uwp/Extensions/StringExtensions.cs

Line 56 in 83a5bce

public static string GetLocalized(this string resourceKey, UIContext uiContext = null)

• ScreenUnitHelper

https://github.com/CommunityToolkit/WindowsCommunityToolkit/blob/main/Microsoft.Toolkit.Uwp/Helpers/ScreenUnitHelper.cs

• Is this bug a regression in the toolkit? If so, what toolkit version did you last see it work:

Steps to Reproduce

• Can this be reproduced in the Sample App? (Either in a sample as-is or with new XAML pasted in the editor.) If so, please provide custom XAML or steps to reproduce. If not, let us know why it can't be reproduced (e.g. more complex setup, environment, dependencies, etc...)

Steps to reproduce the behavior:

1. Given the following environment (Sample App w/ XAML, Project with Isolated setup, etc...)
2. Go to '...'
3. Click on '....'
4. Scroll down to '....'
5. See error

Expected behavior

Screenshots

Environment

NuGet Package(s):

Package Version(s):

Windows 10 Build Number:

• Fall Creators Update (16299)
• April 2018 Update (17134)
• October 2018 Update (17763)
• May 2019 Update (18362)
• May 2020 Update (19041)
• Insider Build ({build_number})

App min and target version:

• Fall Creators Update (16299)
• April 2018 Update (17134)
• October 2018 Update (17763)
• May 2019 Update (18362)
• May 2020 Update (19041)
• Insider Build ({build_number})

Device form factor:

• Desktop
• Xbox
• Surface Hub
• IoT

Visual Studio version:

• 2017 (15.{minor_version})
• 2019 (16.{minor_version})
• 2022 (17.{minor_version})

Additional context

Hello michael-hawker, thank you for opening an issue with us!

I have automatically added a "needs triage" label to help get things started. Our team will analyze and investigate the issue, and escalate it to the relevant team if possible. Other community members may also look into the issue and provide feedback 🙌

[azchohfi]

There is no way to call these in 1809. The APIs literally aren't there.
We have, or should have, equivalents for all of these methods that work on older versions of the OS.
Example:

WindowsCommunityToolkit/Microsoft.Toolkit.Uwp/Extensions/StringExtensions.cs

Line 75 in 83a5bce

public static string GetLocalized(this string resourceKey, string resourcePath)

These methods are "new" and must be used by whoever uses these parts of the toolkit and want to support Xaml Islands (Win32). They should be the only way we support them once we cut 1809 support, in the future.

If there are methods that do not have equivalents, we can use this issue to track them to fix them, but there is just no way to call any XamlRoot API in older versions of the OS.

Edit: Annotation may be useful?

[Windows.Foundation.Metadata.ContractVersion(typeof(Windows.Foundation.UniversalApiContract), 524288)]