Unable to build all projects in solution on the winui branch

[marcelwgn]

When using the winui branch, building the solution wth VS 2022 ends with a few projects failing to build. Build log: https://gist.github.com/chingucoding/5fd6d1cdf7b9e6fd297ce6a2c032b236

Context: I was trying to figure out why unit test projects for WinUI 3 were not working and the awesome @azchohfi suggested to checkout the winui branch and it's unit tests. Since building (and running them didn't work), I'm opening this issue for input and help.

Hello chingucoding, thank you for opening an issue with us!

I have automatically added a "needs triage" label to help get things started. Our team will analyze and investigate the issue, and escalate it to the relevant team if possible. Other community members may also look into the issue and provide feedback 🙌

[azchohfi]

Ah, there is the issue.
The UI Tests are enabled on the winui branch, but the Unit Tests are enabled only on the winui_unittests branch. I still haven't merged these into the winui branch yet, due to an issue that we are still investigating. The issue happens only on our test project that has many, many tests, and we were still not able to reproduce them on projects with only a few (<1000 tests), so you should still be fine when using the MSTest infrastructure.
Btw, how are you executing these? build.cmd from the build folder, or directly through VS?

[marcelwgn]

Ah I see. I'm building the project through Visual Studio. The first times it failed, but after running the build.bat file inside the build folder, the build errors for the UI tests project didn't seem to occur again and the tests ran fine. After cleaning the projects again though, trying to run the UI tests ended in a build issues and the tests not running.

[michael-hawker]

@azchohfi you mentioned you've merged these two branches together now I think, eh?

[azchohfi]

Yes, the winui_unittests branch was merged into the winui branch.

[michael-hawker]

@chingucoding let us know if you have better luck now and what issues still remain.

[marcelwgn]

Well using VS, I'm still getting build errors https://gist.github.com/chingucoding/97da4bce3c21beead463ba85396c0518
It seems that it fails to download some dependencies properly, could I be missing the link to a NuGet repository?

Btw, tests seem to be running now.

Btw², it seems that you also have the issue of the UI being created and not cleaned up; is that worth looking into?

[michael-hawker]

Well using VS, I'm still getting build errors https://gist.github.com/chingucoding/97da4bce3c21beead463ba85396c0518 It seems that it fails to download some dependencies properly, could I be missing the link to a NuGet repository?

The SampleApp won't build in the branch out-of-the-box at the moment as there's not a package of the Monaco editor for WinUI 3 yet, that has to be built manually from Alex's branch in that repo. Eventually hope to have a package using WebView2 for it across platforms, but have been waiting for WebView2 to support hosting objects for scripting interop vs. doing manual messaging.

Btw², it seems that you also have the issue of the UI being created and not cleaned up; is that worth looking into?

Is this only in WinUI or in UWP as well? Definitely appreciate any insight.

[marcelwgn]

Well using VS, I'm still getting build errors https://gist.github.com/chingucoding/97da4bce3c21beead463ba85396c0518 It seems that it fails to download some dependencies properly, could I be missing the link to a NuGet repository?

The SampleApp won't build in the branch out-of-the-box at the moment as there's not a package of the Monaco editor for WinUI 3 yet, that has to be built manually from Alex's branch in that repo. Eventually hope to have a package using WebView2 for it across platforms, but have been waiting for WebView2 to support hosting objects for scripting interop vs. doing manual messaging.

Ah I see, that makes sense. So to a degree those build failures are expected. Should this issue be kept open then so people know that this is (partially) expected?

Btw², it seems that you also have the issue of the UI being created and not cleaned up; is that worth looking into?

Is this only in WinUI or in UWP as well? Definitely appreciate any insight.

UWP test apps don't exhibit this behavior, so far only WinUI 3 apps do this (at least from what I have seen).

[azchohfi]

You should still be able to build the solution from VS if you target Release/AnyCPU. That should not build the sample app and should just work. Or just run the build.bat command from the build folder.