Skip to content

Commit bae8f5f

Browse files
committed
Updated to work with LAMMPS stable_29Oct2020
- Breaks combination with older LAMMPS
1 parent 34ac746 commit bae8f5f

File tree

2 files changed

+12
-11
lines changed

2 files changed

+12
-11
lines changed

src/interface/LAMMPS/src/USER-NNP/pair_nnp.cpp

+8-8
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,13 @@
99
#include "pair_nnp.h"
1010
#include "atom.h"
1111
#include "comm.h"
12-
#include "force.h"
1312
#include "neighbor.h"
1413
#include "neigh_list.h"
1514
#include "neigh_request.h"
1615
#include "memory.h"
1716
#include "error.h"
1817
#include "update.h"
18+
#include "utils.h"
1919

2020
using namespace LAMMPS_NS;
2121

@@ -130,13 +130,13 @@ void PairNNP::settings(int narg, char **arg)
130130
} else if (strcmp(arg[iarg],"showewsum") == 0) {
131131
if (iarg+2 > narg)
132132
error->all(FLERR,"Illegal pair_style command");
133-
showewsum = force->inumeric(FLERR,arg[iarg+1]);
133+
showewsum = utils::inumeric(FLERR,arg[iarg+1],false,lmp);
134134
iarg += 2;
135135
// maximum allowed extrapolation warnings
136136
} else if (strcmp(arg[iarg],"maxew") == 0) {
137137
if (iarg+2 > narg)
138138
error->all(FLERR,"Illegal pair_style command");
139-
maxew = force->inumeric(FLERR,arg[iarg+1]);
139+
maxew = utils::inumeric(FLERR,arg[iarg+1],false,lmp);
140140
iarg += 2;
141141
// reset extrapolation warning counter
142142
} else if (strcmp(arg[iarg],"resetew") == 0) {
@@ -153,13 +153,13 @@ void PairNNP::settings(int narg, char **arg)
153153
} else if (strcmp(arg[iarg],"cflength") == 0) {
154154
if (iarg+2 > narg)
155155
error->all(FLERR,"Illegal pair_style command");
156-
cflength = force->numeric(FLERR,arg[iarg+1]);
156+
cflength = utils::numeric(FLERR,arg[iarg+1],false,lmp);
157157
iarg += 2;
158158
// energy unit conversion factor
159159
} else if (strcmp(arg[iarg],"cfenergy") == 0) {
160160
if (iarg+2 > narg)
161161
error->all(FLERR,"Illegal pair_style command");
162-
cfenergy = force->numeric(FLERR,arg[iarg+1]);
162+
cfenergy = utils::numeric(FLERR,arg[iarg+1],false,lmp);
163163
iarg += 2;
164164
} else error->all(FLERR,"Illegal pair_style command");
165165
}
@@ -176,10 +176,10 @@ void PairNNP::coeff(int narg, char **arg)
176176
if (narg != 3) error->all(FLERR,"Incorrect args for pair coefficients");
177177

178178
int ilo,ihi,jlo,jhi;
179-
force->bounds(FLERR,arg[0],atom->ntypes,ilo,ihi);
180-
force->bounds(FLERR,arg[1],atom->ntypes,jlo,jhi);
179+
utils::bounds(FLERR,arg[0],1,atom->ntypes,ilo,ihi,error);
180+
utils::bounds(FLERR,arg[1],1,atom->ntypes,jlo,jhi,error);
181181

182-
maxCutoffRadius = force->numeric(FLERR,arg[2]);
182+
maxCutoffRadius = utils::numeric(FLERR,arg[2],false,lmp);
183183

184184
// TODO: Check how this flag is set.
185185
int count = 0;

src/interface/makefile

+4-3
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ COMP=gnu
2020
MODE=static
2121

2222
# LAMMPS version string
23-
LAMMPS_VERSION=stable_3Mar2020
23+
LAMMPS_VERSION=stable_29Oct2020
2424

2525
# Include global (project-wide) settings.
2626
include $(PROJECT_DIR)/src/makefile.$(COMP)
@@ -38,6 +38,7 @@ clean: clean-lammps-nnp
3838
##############
3939
# lammps-nnp #
4040
##############
41+
LAMMPS_DEBUG := $(filter-out -pedantic-errors,$(PROJECT_DEBUG))
4142
lammps-nnp:
4243
if [ ! -e $(LAMMPS_VERSION).tar.gz ]; then \
4344
wget https://github.com/lammps/lammps/archive/$(LAMMPS_VERSION).tar.gz; \
@@ -50,8 +51,8 @@ lammps-nnp:
5051
@sed -i.bak "s/^LINK .*$$/LINK = $(PROJECT_MPICC)/" lammps-nnp/src/MAKE/Makefile.mpi
5152
@sed -i.bak "s/^LINKFLAGS .*$$/LINKFLAGS = $(PROJECT_CFLAGS) $(PROJECT_CFLAGS_MPI)/" lammps-nnp/src/MAKE/Makefile.mpi
5253
if [ "$(MODE)" = "test" ]; then \
53-
sed -i.bak "/^CCFLAGS =/ s/$$/ $(PROJECT_DEBUG) $(PROJECT_TEST)/" lammps-nnp/src/MAKE/Makefile.mpi; \
54-
sed -i.bak "/^LINKFLAGS =/ s/$$/ $(PROJECT_DEBUG) $(PROJECT_TEST)/" lammps-nnp/src/MAKE/Makefile.mpi; \
54+
sed -i.bak "/^CCFLAGS =/ s/$$/ $(LAMMPS_DEBUG) $(PROJECT_TEST)/" lammps-nnp/src/MAKE/Makefile.mpi; \
55+
sed -i.bak "/^LINKFLAGS =/ s/$$/ $(LAMMPS_DEBUG) $(PROJECT_TEST)/" lammps-nnp/src/MAKE/Makefile.mpi; \
5556
fi
5657
@rm lammps-nnp/src/MAKE/Makefile.mpi.bak
5758
cd lammps-nnp/src/ && $(MAKE) yes-user-nnp && $(MAKE) yes-molecule && $(MAKE) mpi

0 commit comments

Comments
 (0)