feat(docs): SEO enhancements and page feedback #2341
Closed
+481
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SEO improvements: - JSON-LD TechArticle schema for search engines - Proper TOC sidebar layout (removed main wrapper) - Updated source.config.ts for better content handling Page feedback: - feedback.tsx - Page rating component - /api/feedback - Feedback collection endpoint 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
|
Cant see any feedback button: @sohamganatra |
- source.config.ts: Add keywords field to docsSchema for search indexing (Zod strips unknown keys by default, so keywords weren't being passed) - feedback.tsx: Prevent duplicate submissions by adding isSubmitting state, disabling buttons during submission, and awaiting async calls - feedback.tsx: Remove invalid aria-describedby referencing non-existent hint 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
| </div> | ||
| )} | ||
| </div> | ||
| ); |
There was a problem hiding this comment.
Feedback component created but never rendered on pages
High Severity
The Feedback component is fully implemented but never imported or rendered anywhere in the application. The component exists in fumadocs/components/feedback.tsx and the API endpoint in /api/feedback is created, but the Feedback component is not added to the docs page.tsx layout nor included in mdx-components.tsx for MDX usage. This explains the PR comment from a user who cannot see any feedback button. The entire page feedback feature is non-functional because the UI component is never displayed.
Additional Locations (1)
Contributor
Author
|
Superseded by smaller PRs for easier review:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds SEO improvements and page feedback functionality.
SEO Improvements
Page Feedback
feedback.tsx- Thumbs up/down rating component/api/feedback- Feedback collection endpointTest Plan
🤖 Generated with Claude Code