Split Repo: Server & Client

[ax3l]

Since the server and clients share no code with the isaac library (not even headers) we should split them in separate repos.

This will ease packing, e.g., spack recipes for library & server.

• add "protocol_version" attribute to json so server and client can check & abort on protocol mismatch for further development with breaking in-JSON-protocol changes

[theZiz]

I guess this is a good idea, but in which direction? A new server repository or a new library repository? I guess the first idea makes more sense as PIConGPU and the documentation of it does not needed to get touched for this.

But nevertheless: What is the problem creating two recipes for spack? They both use the same repository, but could also use different CMake-variables. So maybe just improving the CMakeLists.txt may make sense, too?

[ax3l]

my suggestion similar to popular naming schemes:

• keep the library in isaac
• move the clients to isaac-clients or isaac-html
• move the server to isaac-server

and don't forget about he protocol_version stringy.

But nevertheless: What is the problem creating two recipes for spack? They both use the same repository, but could also use different CMake-variables. So maybe just improving the CMakeLists.txt may make sense, too?

Yes, allowing to build & install the server and library cleanly and separately would also help to solve that issue. I would still introduce a protocol_version since we already use independent server and library versions of ISAAC in production.

[theZiz]

Althought this should have been in another issue, I implemented the protocol version check: 6ab1b3d
Furthermore I made it optional to not build/install the server or the library. I am still not sure, whether it is a good idea to split the repositories. The solution should work with spack for now: 62156d3

[ax3l]

awesome, thanks!

yeah, the split of at least the CMakeLists.txt files would be useful, since flags such as -DISAAC_GST=OFF make no sense for a library-only or client-only install.

[theZiz]

Yes. But if you make cmake -DISAAC_BUILD_SERVER=OFF .. it doesn't show ISAAC_GST to you (at least in ccmake).

[ax3l]

but INSTALL.md does and it confuses people trying to use specific, minimal aspect of ISAAC.

We should split the CMakeLists.txt, client and server at least in the repo so they look like, build and install individual projects depending on one another

[theZiz]

Okay, sounds like a good compromise.

[theZiz]

Done: 1801b97
Works fine on my machine, but I can't test today on the cluster for obvious reasons. ;)

[ax3l]

thanks, added some inline comments in the commit above regarding the updates in INSTALL.md

[theZiz]

Thanks for you comments. Fixed them: dcf4a0f