Skip to content

Commit 64a0805

Browse files
authored
Merge pull request #387 from ComputerScienceHouse/no-more-x
Fix x functionality on not home page
2 parents d84ec66 + b6c35bc commit 64a0805

4 files changed

Lines changed: 18 additions & 11 deletions

File tree

_includes/nav.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
<div id="info-banner">
44
<p>ATTENTION ALUMNI & MEMBERS: The 50th Anniversary will be held from April 10th-12th, 2026!</p>
55
<p>Find out more at <a href="https://50th.csh.rit.edu">50th.csh.rit.edu</a></p>
6-
<button id="close-banner"></button>
6+
<button id="close-banner" onclick="document.getElementById('info-banner').style.display='none'"></button>
77
</div>
88

99
<div class="container">

_sass/_splash.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ $size: 350px;
1212
h1 {
1313
color: white;
1414
font-size: 3em;
15-
margin: 0;
15+
margin: 40px 0 0;
1616
padding: 0 1rem;
1717
max-width: 100%;
1818
word-wrap: break-word;

assets/css/main.scss

Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,14 +159,16 @@ a.btn {
159159
background-color: #B0197E;
160160
color: #fff;
161161
text-align: center;
162-
padding: 10px 20px;
162+
padding: 10px 40px;
163163
width: 100%;
164164
box-shadow: 0 2px 5px rgba(0, 0, 0, 0.1);
165165
}
166166

167167
#info-banner p {
168168
margin: 0;
169169
display: inline-block;
170+
171+
position: relative;
170172
}
171173

172174
#close-banner {
@@ -176,6 +178,11 @@ a.btn {
176178
cursor: pointer;
177179
margin-left: 10px;
178180
color: #fff;
181+
182+
183+
position: fixed;
184+
top: 10px;
185+
right: 20px;
179186
}
180187

181188
#info-banner a {
@@ -187,6 +194,14 @@ a.btn {
187194
color: white;
188195
}
189196

197+
@media screen and (min-width: 1100px) {
198+
#close-banner {
199+
top: 20px;
200+
right: 30px;
201+
}
202+
}
203+
204+
190205
@import "typography";
191206
@import "nav";
192207
@import "slider";

index.html

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -241,11 +241,3 @@ <h2 class="header">Sponsors</h2>
241241
</div>
242242
</div>
243243
</div>
244-
245-
<!-- Javascript for 50th Info Banner -->
246-
<script>
247-
// Close banner functionality
248-
document.getElementById('close-banner').addEventListener('click', function() {
249-
document.getElementById('info-banner').style.display = 'none';
250-
});
251-
</script>

0 commit comments

Comments
 (0)