Fix clippy warning

Author: limemloh

collector/src/bin/collector.rs

@@ -11,7 +11,11 @@ use tonic::transport::{channel::Channel, ClientTlsConfig};
 #[macro_use]
 extern crate log;
 
-#[allow(clippy::large_enum_variant, clippy::enum_variant_names)]
+#[allow(
+    clippy::large_enum_variant,
+    clippy::enum_variant_names,
+    clippy::doc_overindented_list_items
+)]
 mod grpc {
     mod plt {
         tonic::include_proto!("concordium.v2.plt");
@@ -208,7 +212,7 @@ async fn main() {
 }
 
 #[allow(clippy::cognitive_complexity)]
-async fn collect_data<'a>(
+async fn collect_data(
     node_name: NodeName,
     grpc_host: String,
     conf: &ConfigCli,

concordium-node/src/bin/bootstrap_checker.rs

@@ -37,7 +37,7 @@ fn main() -> anyhow::Result<()> {
     let regenesis_arc: Arc<Regenesis> = Arc::new(Regenesis::from_blocks(regenesis_blocks));
 
     ensure!(
-        regenesis_arc.blocks.read().unwrap().len() > 0,
+        !regenesis_arc.blocks.read().unwrap().is_empty(),
         "Bootstrapper can't run without specifying genesis hashes."
     );
 

concordium-node/src/bin/bootstrapper.rs

@@ -40,7 +40,7 @@ async fn main() -> anyhow::Result<()> {
     let regenesis_arc: Arc<Regenesis> = Arc::new(Regenesis::from_blocks(regenesis_blocks));
 
     ensure!(
-        regenesis_arc.blocks.read().unwrap().len() > 0,
+        !regenesis_arc.blocks.read().unwrap().is_empty(),
         "Bootstrapper can't run without specifying genesis hashes."
     );
 

concordium-node/src/consensus_ffi/ffi.rs

@@ -2383,7 +2383,7 @@ impl ConsensusContainer {
         use crate::grpc2::Require;
         let bhi = crate::grpc2::types::block_hash_input_to_ffi(block_hash).require()?;
         let (block_id_type, block_hash) = bhi.to_ptr();
-        let token_id_len = token_id.value.as_bytes().len();
+        let token_id_len = token_id.value.len();
         if token_id_len > 255 {
             return Err(tonic::Status::invalid_argument(
                 "TokenId: length must be at most 255 bytes",

concordium-node/src/health.rs

@@ -51,7 +51,7 @@ enum ServiceError<'a> {
     ServiceNotFound { service: &'a str },
 }
 
-impl<'a> ServiceError<'a> {
+impl ServiceError<'_> {
     pub fn is_not_found(&self) -> bool {
         matches!(self, Self::ServiceNotFound { .. })
     }