Skip to content

Commit 3fa9152

Browse files
committed
fix: add release environment
1 parent 4658ef5 commit 3fa9152

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

.github/workflows/test-windows-code-signing.yaml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,8 @@ jobs:
7878
echo "docker_tags=${{ env.DOCKER_TAGS_TEMPLATES }}" >> $GITHUB_OUTPUT
7979
8080
node-windows:
81-
runs-on: windows-latest
81+
runs-on: windows-latest
82+
environment: release # This step needs to use the release context to access credentials for code signing.
8283
needs: [validate-preconditions]
8384
if: contains(fromJSON('["rc", "alpha", "node-windows"]'), needs.validate-preconditions.outputs.release_type)
8485
defaults:
@@ -125,7 +126,7 @@ jobs:
125126
SM_CLIENT_CERT_FILE: ${{ steps.windows_certificate.outputs.CERTIFICATE_PATH }}
126127
SM_CLIENT_CERT_PASSWORD: ${{ secrets.WINDOWS_SM_CLIENT_CERT_PASSWORD }}
127128
run: |
128-
smctl healthcheck --tools --verbose
129+
smctl healthcheck --all
129130
# smctl sign --verbose --keypair-alias ${{ env.WINDOWS_SM_KEYPAIR_ALIAS }} --input ${{ env.FILE_TO_SIGN }} --config-file ${{ env.WINDOWS_PKCS11_CONFIG }} --verbose --exit-non-zero-on-fail --failfast
130131
shell: cmd
131132

0 commit comments

Comments
 (0)