Skip to content

Commit a726d30

Browse files
nb-ccdnb-ccd
committed
fix: dont sign just build
1 parent b1964c7 commit a726d30

File tree

1 file changed

+46
-44
lines changed

1 file changed

+46
-44
lines changed

‎.github/workflows/test-windows-code-signing.yaml‎

Lines changed: 46 additions & 44 deletions
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ jobs:
8080
8181
node-windows:
8282
runs-on: windows-latest
83-
environment: release # This step needs to use the release context to access credentials for code signing.
83+
# environment: release # This step needs to use the release context to access credentials for code signing.
8484
needs: [validate-preconditions]
8585
if: contains(fromJSON('["rc", "alpha", "node-windows"]'), needs.validate-preconditions.outputs.release_type)
8686
defaults:
@@ -102,18 +102,18 @@ jobs:
102102
id: digicert_client
103103
uses: digicert/[email protected]
104104

105-
- name: Import Windows certificate (Windows only)
106-
id: windows_certificate
107-
env:
108-
# Base64 encoding of the pfx/p12 certificate for Windows code signing.
109-
SM_CLIENT_CERT_FILE_B64: ${{ secrets.WINDOWS_SM_CLIENT_CERT_FILE_B64 }}
110-
run: |
111-
$CERTIFICATE_PATH_BASE64="$env:RUNNER_TEMP\cert-b64.txt"
112-
$CERTIFICATE_PATH="$env:RUNNER_TEMP\cert.pfx"
105+
# - name: Import Windows certificate (Windows only)
106+
# id: windows_certificate
107+
# env:
108+
# # Base64 encoding of the pfx/p12 certificate for Windows code signing.
109+
# SM_CLIENT_CERT_FILE_B64: ${{ secrets.WINDOWS_SM_CLIENT_CERT_FILE_B64 }}
110+
# run: |
111+
# $CERTIFICATE_PATH_BASE64="$env:RUNNER_TEMP\cert-b64.txt"
112+
# $CERTIFICATE_PATH="$env:RUNNER_TEMP\cert.pfx"
113113

114-
Set-Content -Path $CERTIFICATE_PATH_BASE64 -Value $env:SM_CLIENT_CERT_FILE_B64
115-
certutil -decode $CERTIFICATE_PATH_BASE64 $CERTIFICATE_PATH
116-
echo "CERTIFICATE_PATH=$CERTIFICATE_PATH" >> $env:GITHUB_OUTPUT
114+
# Set-Content -Path $CERTIFICATE_PATH_BASE64 -Value $env:SM_CLIENT_CERT_FILE_B64
115+
# certutil -decode $CERTIFICATE_PATH_BASE64 $CERTIFICATE_PATH
116+
# echo "CERTIFICATE_PATH=$CERTIFICATE_PATH" >> $env:GITHUB_OUTPUT
117117

118118
- name: Run smctl healthcheck to confirm if the tool is configured properly.
119119
working-directory: ${{steps.build.outputs.bin_dir}}
@@ -189,6 +189,7 @@ jobs:
189189
MsiDb.exe -d ./service/windows/installer/Node.msi -x Node.cab
190190
mkdir Node
191191
dir
192+
expand -d Node.cab
192193
expand -F:* Node.cab ./Node
193194
dir Node
194195
shell: cmd
@@ -203,25 +204,25 @@ jobs:
203204
mv ./Node/NodeCollector ./Node/NodeCollector.exe
204205
mv ./Node/ConcordiumNode ./Node/ConcordiumNode.exe
205206
206-
- name: Sign files with smctl
207-
working-directory: ${{steps.build.outputs.bin_dir}}
208-
env:
209-
WINDOWS_PKCS11_CONFIG: ${{ steps.digicert_client.outputs.PKCS11_CONFIG }}
210-
WINDOWS_SM_KEYPAIR_ALIAS: ${{ secrets.WINDOWS_SM_KEYPAIR_ALIAS }}
211-
SM_HOST: ${{ vars.WINDOWS_SM_HOST }}
212-
SM_API_KEY: ${{ secrets.WINDOWS_SM_API_KEY }}
213-
SM_CLIENT_CERT_FILE: ${{ steps.windows_certificate.outputs.CERTIFICATE_PATH }}
214-
SM_CLIENT_CERT_PASSWORD: ${{ secrets.WINDOWS_SM_CLIENT_CERT_PASSWORD }}
215-
SM_ARGS: "--verbose --exit-non-zero-on-fail --failfast"
216-
run: |
217-
smctl sign --keypair-alias ${{ env.WINDOWS_SM_KEYPAIR_ALIAS }} --input ./Node/ConcordiumConsensusDLL.dll --config-file ${{ env.WINDOWS_PKCS11_CONFIG }} ${{ env.SM_ARGS }}
218-
smctl sign --keypair-alias ${{ env.WINDOWS_SM_KEYPAIR_ALIAS }} --input ./Node/ConcordiumBaseDLL.dll --config-file ${{ env.WINDOWS_PKCS11_CONFIG }} ${{ env.SM_ARGS }}
219-
smctl sign --keypair-alias ${{ env.WINDOWS_SM_KEYPAIR_ALIAS }} --input ./Node/ConcordiumSmartContractEngineDLL.dll --config-file ${{ env.WINDOWS_PKCS11_CONFIG }} ${{ env.SM_ARGS }}
220-
smctl sign --keypair-alias ${{ env.WINDOWS_SM_KEYPAIR_ALIAS }} --input ./Node/Sha2DLL.dll --config-file ${{ env.WINDOWS_PKCS11_CONFIG }} ${{ env.SM_ARGS }}
221-
smctl sign --keypair-alias ${{ env.WINDOWS_SM_KEYPAIR_ALIAS }} --input ./Node/NodeRunnerService.exe --config-file ${{ env.WINDOWS_PKCS11_CONFIG }} ${{ env.SM_ARGS }}
222-
smctl sign --keypair-alias ${{ env.WINDOWS_SM_KEYPAIR_ALIAS }} --input ./Node/NodeCollector.exe --config-file ${{ env.WINDOWS_PKCS11_CONFIG }} ${{ env.SM_ARGS }}
223-
smctl sign --keypair-alias ${{ env.WINDOWS_SM_KEYPAIR_ALIAS }} --input ./Node/ConcordiumNode.exe --config-file ${{ env.WINDOWS_PKCS11_CONFIG }} ${{ env.SM_ARGS }}
224-
shell: cmd
207+
# - name: Sign files with smctl
208+
# working-directory: ${{steps.build.outputs.bin_dir}}
209+
# env:
210+
# WINDOWS_PKCS11_CONFIG: ${{ steps.digicert_client.outputs.PKCS11_CONFIG }}
211+
# WINDOWS_SM_KEYPAIR_ALIAS: ${{ secrets.WINDOWS_SM_KEYPAIR_ALIAS }}
212+
# SM_HOST: ${{ vars.WINDOWS_SM_HOST }}
213+
# SM_API_KEY: ${{ secrets.WINDOWS_SM_API_KEY }}
214+
# SM_CLIENT_CERT_FILE: ${{ steps.windows_certificate.outputs.CERTIFICATE_PATH }}
215+
# SM_CLIENT_CERT_PASSWORD: ${{ secrets.WINDOWS_SM_CLIENT_CERT_PASSWORD }}
216+
# SM_ARGS: "--verbose --exit-non-zero-on-fail --failfast"
217+
# run: |
218+
# smctl sign --keypair-alias ${{ env.WINDOWS_SM_KEYPAIR_ALIAS }} --input ./Node/ConcordiumConsensusDLL.dll --config-file ${{ env.WINDOWS_PKCS11_CONFIG }} ${{ env.SM_ARGS }}
219+
# smctl sign --keypair-alias ${{ env.WINDOWS_SM_KEYPAIR_ALIAS }} --input ./Node/ConcordiumBaseDLL.dll --config-file ${{ env.WINDOWS_PKCS11_CONFIG }} ${{ env.SM_ARGS }}
220+
# smctl sign --keypair-alias ${{ env.WINDOWS_SM_KEYPAIR_ALIAS }} --input ./Node/ConcordiumSmartContractEngineDLL.dll --config-file ${{ env.WINDOWS_PKCS11_CONFIG }} ${{ env.SM_ARGS }}
221+
# smctl sign --keypair-alias ${{ env.WINDOWS_SM_KEYPAIR_ALIAS }} --input ./Node/Sha2DLL.dll --config-file ${{ env.WINDOWS_PKCS11_CONFIG }} ${{ env.SM_ARGS }}
222+
# smctl sign --keypair-alias ${{ env.WINDOWS_SM_KEYPAIR_ALIAS }} --input ./Node/NodeRunnerService.exe --config-file ${{ env.WINDOWS_PKCS11_CONFIG }} ${{ env.SM_ARGS }}
223+
# smctl sign --keypair-alias ${{ env.WINDOWS_SM_KEYPAIR_ALIAS }} --input ./Node/NodeCollector.exe --config-file ${{ env.WINDOWS_PKCS11_CONFIG }} ${{ env.SM_ARGS }}
224+
# smctl sign --keypair-alias ${{ env.WINDOWS_SM_KEYPAIR_ALIAS }} --input ./Node/ConcordiumNode.exe --config-file ${{ env.WINDOWS_PKCS11_CONFIG }} ${{ env.SM_ARGS }}
225+
# shell: cmd
225226

226227
- name: Rename files back to their original form without extension.
227228
run: |
@@ -243,22 +244,23 @@ jobs:
243244
run: |
244245
rm Node.cab
245246
mv disk1\Node.cab .
247+
expand -d Node.cab
246248
MsiDb.exe -d ./service/windows/installer/Node.msi -k Node.cab
247249
MsiDb.exe -d ./service/windows/installer/Node.msi -a Node.cab
248250
249-
- name: Sign files with smctl
250-
working-directory: ${{steps.build.outputs.bin_dir}}
251-
env:
252-
WINDOWS_PKCS11_CONFIG: ${{ steps.digicert_client.outputs.PKCS11_CONFIG }}
253-
WINDOWS_SM_KEYPAIR_ALIAS: ${{ secrets.WINDOWS_SM_KEYPAIR_ALIAS }}
254-
SM_HOST: ${{ vars.WINDOWS_SM_HOST }}
255-
SM_API_KEY: ${{ secrets.WINDOWS_SM_API_KEY }}
256-
SM_CLIENT_CERT_FILE: ${{ steps.windows_certificate.outputs.CERTIFICATE_PATH }}
257-
SM_CLIENT_CERT_PASSWORD: ${{ secrets.WINDOWS_SM_CLIENT_CERT_PASSWORD }}
258-
SM_ARGS: "--verbose --exit-non-zero-on-fail --failfast"
259-
run: |
260-
smctl sign --keypair-alias ${{ env.WINDOWS_SM_KEYPAIR_ALIAS }} --input ./service/windows/installer/Node.msi --config-file ${{ env.WINDOWS_PKCS11_CONFIG }} ${{ env.SM_ARGS }}
261-
shell: cmd
251+
# - name: Sign files with smctl
252+
# working-directory: ${{steps.build.outputs.bin_dir}}
253+
# env:
254+
# WINDOWS_PKCS11_CONFIG: ${{ steps.digicert_client.outputs.PKCS11_CONFIG }}
255+
# WINDOWS_SM_KEYPAIR_ALIAS: ${{ secrets.WINDOWS_SM_KEYPAIR_ALIAS }}
256+
# SM_HOST: ${{ vars.WINDOWS_SM_HOST }}
257+
# SM_API_KEY: ${{ secrets.WINDOWS_SM_API_KEY }}
258+
# SM_CLIENT_CERT_FILE: ${{ steps.windows_certificate.outputs.CERTIFICATE_PATH }}
259+
# SM_CLIENT_CERT_PASSWORD: ${{ secrets.WINDOWS_SM_CLIENT_CERT_PASSWORD }}
260+
# SM_ARGS: "--verbose --exit-non-zero-on-fail --failfast"
261+
# run: |
262+
# smctl sign --keypair-alias ${{ env.WINDOWS_SM_KEYPAIR_ALIAS }} --input ./service/windows/installer/Node.msi --config-file ${{ env.WINDOWS_PKCS11_CONFIG }} ${{ env.SM_ARGS }}
263+
# shell: cmd
262264

263265
- name: Rename the package to target filename.
264266
run: |

0 commit comments

Comments
 (0)