Skip to content

Commit d629fc3

Browse files
committed
fix: windows shell syntax
1 parent d37543d commit d629fc3

File tree

1 file changed

+6
-7
lines changed

1 file changed

+6
-7
lines changed

.github/workflows/test-windows-code-signing.yaml

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -189,12 +189,12 @@ jobs:
189189
190190
- name: Extract files to prepare for signing
191191
run: |
192-
pwd
193192
dir
194193
MsiDb.exe -d ./service/windows/installer/Node.msi -x Node.cab
194+
mkdir Node
195195
dir
196-
mkdir -p ./Node
197196
expand -F:* Node.cab ./Node
197+
dir Node
198198
shell: cmd
199199

200200
- name: Rename files to prepare for signing
@@ -239,8 +239,8 @@ jobs:
239239
240240
- name: Recreate the cabinet file.
241241
run: |
242-
dir Node /b /a-d > filelist.txt
243-
makecab.exe /D MaxDiskSize=0 /D Cabinet=ON /D Compress=ON /D CabinetName1=Node.cab /D SourceDir=Node /f cabdirs.txt
242+
dir Node /b /a-d > cabfiles.txt
243+
makecab.exe /D MaxDiskSize=0 /D Cabinet=ON /D Compress=ON /D CabinetName1=Node.cab /D SourceDir=Node /f cabfiles.txt
244244
shell: cmd
245245

246246

@@ -250,9 +250,8 @@ jobs:
250250
mv disk1\Node.cab .
251251
MsiDb.exe -d ./service/windows/installer/Node.msi -k Node.cab
252252
MsiDb.exe -d ./service/windows/installer/Node.msi -a Node.cab
253-
shell: cmd
254-
255-
# Sign the installer
253+
254+
# Here we would sign the installer
256255

257256
- name: Rename the package to target filename.
258257
run: |

0 commit comments

Comments
 (0)