Skip to content

Type safe storage#1650

Draft
td202 wants to merge 3 commits into
mainfrom
type-safe-storage
Draft

Type safe storage#1650
td202 wants to merge 3 commits into
mainfrom
type-safe-storage

Conversation

@td202

@td202 td202 commented May 28, 2026

Copy link
Copy Markdown
Contributor

Purpose

_Describe the purpose of the pull request, link to issue describing the problem, etc.

Changes

_Describe the changes that were needed.

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

CLA acceptance

_Remove if not applicable.

By submitting the contribution I accept the terms and conditions of the
Contributor License Agreement v1.0

@td202

td202 commented May 28, 2026

Copy link
Copy Markdown
Contributor Author

@copilot Please identify all changes that are not just to type signatures or comments.

Copilot AI commented May 28, 2026

Copy link
Copy Markdown

@copilot Please identify all changes that are not just to type signatures or comments.

Non-type/comment changes in my branch are limited to a small set of refactors (no intended behavior change):

  • concordium-consensus/src/Concordium/KonsensusV1/SkovMonad.hs
    • Introduced NewSkov wrapper record (nsContext, nsState) and switched tuple construction to that record.
    • Added local type annotations for helpers like initWithLLDB.
  • concordium-consensus/src/Concordium/Skov/MonadImplementations.hs
    • Replaced the InitialisedSkov tuple type alias with an existential data InitialisedSkov ... constructor and updated call sites to construct/pattern-match it.
  • concordium-consensus/src/Concordium/GlobalState/Persistent/Accounts.hs
    • In migrateAccounts, changed canonicalAddress <- accountCanonicalAddress =<< lift (refLoad acct) to canonicalAddress <- lift (accountCanonicalAddress =<< refLoad acct) (equivalent).
  • concordium-consensus/src/Concordium/GlobalState/Persistent/TreeState.hs
    • Removed explicit type application in runPersistentBlockStateMonad @pv call (runPersistentBlockStateMonad a now inferred).
  • Minor text edit in BlobStore.hs comment: “writable” spelling.

Everything else is type-parameter/signature propagation and related constraints.

Copilot finished work on behalf of td202 May 28, 2026 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants