Commit bcdec2d
fix(network): stop demoting healthy peers on simultaneous-dial dedup
`deregister_stream` recorded `node_db.note_failure` for every expired
session it removed, but the simultaneous-dial dedup kill passes
`op = None` (since #3436 / 4ab4a79) precisely to avoid recording a
failure — so the dropped redundant connection demoted the healthy peer
anyway. The same blanket call also dragged a peer back down after it had
already reconnected.
Remove the blanket `note_failure` from `deregister_stream`. Peer
reputation on disconnect is already recorded by the kill path via its
`UpdateNodeOperation` (note_failure / demote / set_blacklisted for remote
failures), and `set_expired` is only ever set by the two kill functions,
so no genuine failure recording is lost.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>1 parent 2dfb5f9 commit bcdec2d
1 file changed
Lines changed: 2 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1814 | 1814 | | |
1815 | 1815 | | |
1816 | 1816 | | |
1817 | | - | |
1818 | | - | |
1819 | | - | |
1820 | | - | |
1821 | | - | |
1822 | | - | |
| 1817 | + | |
| 1818 | + | |
1823 | 1819 | | |
1824 | 1820 | | |
1825 | 1821 | | |
| |||
0 commit comments