Temporary fix for #1138 #1140
Temporary fix for #1138 #1140
Conversation
There was a problem hiding this comment.
Reviewed 2 of 9 files at r1.
Reviewable status: 2 of 9 files reviewed, 5 unresolved discussions (waiting on @yangzhe1990)
core/src/sync/synchronization_protocol_handler.rs, line 1421 at r1 (raw file):
pub fn blocks_received( &self, io: &dyn NetworkContext, requested_hashes_except_blah: HashSet<H256>,
what does "blah" mean?
There was a problem hiding this comment.
Reviewed 1 of 9 files at r1.
Reviewable status: 3 of 9 files reviewed, 6 unresolved discussions (waiting on @yangzhe1990)
core/src/sync/message/get_block_txn.rs, line 55 at r1 (raw file):
// where GetBlockTxn can not be initiated. with_public: false, hashes: vec![self.block_hash.clone()],
why self.clone() is not ok?
There was a problem hiding this comment.
Reviewed 5 of 9 files at r1.
Reviewable status: 8 of 9 files reviewed, 7 unresolved discussions (waiting on @yangzhe1990)
core/src/sync/request_manager/mod.rs, line 661 at r1 (raw file):
pub fn blocks_received( &self, io: &dyn NetworkContext, requested_hashes_except_blah: HashSet<H256>,
same as above
There was a problem hiding this comment.
Reviewable status: 8 of 9 files reviewed, 7 unresolved discussions (waiting on @yangzhe1990)
core/src/sync/message/get_block_txn.rs, line 55 at r1 (raw file):
Previously, sparkmiw wrote…
why self.clone() is not ok?
oh, I got it.
There was a problem hiding this comment.
Reviewed 1 of 9 files at r1.
Reviewable status: all files reviewed, 6 unresolved discussions (waiting on @yangzhe1990)
yangzhe1990
force-pushed
the
refactor_send_request
branch
from
591db6c to
037bbd0
Compare
…do not send the request again, instead send GetBlocks request.
yangzhe1990
force-pushed
the
refactor_send_request
branch
from
037bbd0 to
23b2719
Compare
There was a problem hiding this comment.
Reviewable status: 4 of 8 files reviewed, 2 unresolved discussions (waiting on @sparkmiw)
core/src/sync/synchronization_protocol_handler.rs, line 1421 at r1 (raw file):
Previously, sparkmiw wrote…
what does "blah" mean?
Done.
core/src/sync/request_manager/mod.rs, line 661 at r1 (raw file):
Previously, sparkmiw wrote…
same as above
Done.
There was a problem hiding this comment.
Reviewed 4 of 5 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved
When GetBlockTxn is timed out, do not send the request again, instead send GetBlocks request.
Some namings are changed along with this PR.
This change is