Commit 337323b
[Postgres] Remove incorrect empty_default_hostname warning (DataDog#23082)
* [Postgres] Hide empty_default_hostname and remove incorrect warning
The Postgres check uses `exclude_hostname` instead of `empty_default_hostname`
for hostname exclusion. However, `empty_default_hostname` was still documented
in the example config (inherited from the global template) and the Cluster Agent
injects it unconditionally on all cluster checks, causing a confusing warning.
This change:
- Hides `empty_default_hostname` from the Postgres conf.yaml.example
- Removes the warning that fired when the option was set
- Removes the associated test
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* Restore empty_default_hostname in EXPECTED_DEFAULTS
The field still exists in InstanceConfig (hidden only affects the
example file), so the defaults test requires it.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* Fix changelog entry PR number
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* Fix conf.yaml.example: hand-edit removal, restore models to master
The old local ddev (v14.0.1) was generating a different format than CI
expects. Instead, start from master's conf.yaml.example and only remove
the empty_default_hostname block. Restore config models to master state
since they should not change for this PR.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* Simplify PR: only remove the warning, keep empty_default_hostname in config
The option is not completely unused — revert spec.yaml, conf.yaml.example,
and model changes. Only remove the warning in config.py and its test.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* Remove accidentally staged unrelated file
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* Update changelog wording
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>1 parent c12e744 commit 337323b
3 files changed
Lines changed: 1 addition & 15 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
390 | 390 | | |
391 | 391 | | |
392 | 392 | | |
393 | | - | |
394 | | - | |
395 | | - | |
396 | | - | |
397 | | - | |
398 | | - | |
399 | 393 | | |
400 | 394 | | |
401 | 395 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
153 | 153 | | |
154 | 154 | | |
155 | 155 | | |
156 | | - | |
157 | | - | |
158 | | - | |
159 | | - | |
160 | | - | |
161 | | - | |
162 | | - | |
163 | | - | |
164 | | - | |
165 | 156 | | |
166 | 157 | | |
167 | 158 | | |
| |||
0 commit comments