[NDMC-191] collect is physical from cisco aci (DataDog#22537)

* collect is physical from cisco aci

* add test

* fix test

Author: jedupau

cisco_aci/datadog_checks/cisco_aci/models.py

@@ -226,6 +226,7 @@ class InterfaceMetadata(BaseModel):
     admin_status: Optional[AdminStatus] = Field(default=None)
     oper_status: Optional[OperStatus] = Field(default=None)
     integration: Optional[str] = Field(default='cisco-aci')
+    is_physical: Optional[bool] = Field(default=None)
 
     model_config = ConfigDict(validate_assignment=True, use_enum_values=True)
 

cisco_aci/datadog_checks/cisco_aci/ndm.py

@@ -65,6 +65,7 @@ def create_interface_metadata(phys_if, address, namespace):
         description=eth.attributes.desc,
         mac_address=eth.attributes.router_mac,
         admin_status=eth.attributes.admin_st,
+        is_physical=True,
     )
     if eth.ethpm_phys_if:
         interface.oper_status = eth.ethpm_phys_if.attributes.oper_st

cisco_aci/tests/fixtures/metadata.py

@@ -145,6 +145,7 @@
         'name': 'eth1/1',
         'oper_status': 1,
         'status': 'up',
+        'is_physical': True,
     },
     {
         'admin_status': 1,
@@ -160,6 +161,7 @@
         'name': 'eth1/2',
         'oper_status': 1,
         'status': 'up',
+        'is_physical': True,
     },
     {
         'admin_status': 1,
@@ -175,6 +177,7 @@
         'name': 'eth1/3',
         'oper_status': 2,
         'status': 'down',
+        'is_physical': True,
     },
     {
         'admin_status': 1,
@@ -190,6 +193,7 @@
         'name': 'eth1/1',
         'oper_status': 1,
         'status': 'up',
+        'is_physical': True,
     },
     {
         'admin_status': 1,
@@ -205,6 +209,7 @@
         'name': 'eth1/2',
         'oper_status': 1,
         'status': 'up',
+        'is_physical': True,
     },
     {
         'admin_status': 1,
@@ -220,6 +225,7 @@
         'name': 'eth1/3',
         'oper_status': 2,
         'status': 'down',
+        'is_physical': True,
     },
     {
         'admin_status': 1,
@@ -235,6 +241,7 @@
         'name': 'eth5/1',
         'oper_status': 1,
         'status': 'up',
+        'is_physical': True,
     },
     {
         'admin_status': 1,
@@ -250,6 +257,7 @@
         'name': 'eth5/2',
         'oper_status': 1,
         'status': 'up',
+        'is_physical': True,
     },
     {
         'admin_status': 1,
@@ -265,6 +273,7 @@
         'name': 'eth7/1',
         'oper_status': 2,
         'status': 'down',
+        'is_physical': True,
     },
 ]