Prevent AttributeError when Proxmox Metric Server is not configured (DataDog#22698)

* Handle non-200 HTTP response from /cluster/metrics/export when Proxmox Metric Server is not configured to prevent AttributeError

* Add changelog

* Lint

* Remove unnecessary comments

* Refactor the test to use parametrization

* Fix formatting

Author: alexeypilyugin

proxmox/changelog.d/22698.fixed

@@ -0,0 +1 @@
+Handle non-200 HTTP response from /cluster/metrics/export when Proxmox Metric Server is not configured to prevent AttributeError.

proxmox/datadog_checks/proxmox/check.py

@@ -224,6 +224,12 @@ def _collect_ha_metrics(self):
     def _collect_performance_metrics(self):
         self.log.debug("Collecting performance metrics")
         metrics_response = self.http.get(f"{self.config.proxmox_server}/cluster/metrics/export")
+        if not metrics_response.ok:
+            self.log.warning(
+                "Performance metrics endpoint not available (HTTP %s), skipping collection",
+                metrics_response.status_code,
+            )
+            return
         metrics_response_json = metrics_response.json()
         metrics = metrics_response_json.get('data', {}).get('data', [])
 

proxmox/tests/test_unit.py

@@ -485,6 +485,29 @@ def test_perf_metrics(dd_run_check, aggregator, instance):
         aggregator.assert_metric(metric, count=0, tags=pool_tags)
 
 
+@pytest.mark.parametrize(
+    ('mock_http_get'),
+    [
+        pytest.param(
+            {'http_error': {'/api2/json/cluster/metrics/export': MockResponse(status_code=501)}},
+            id='501',
+        ),
+    ],
+    indirect=['mock_http_get'],
+)
+@pytest.mark.usefixtures('mock_http_get')
+def test_performance_metrics_endpoint_unavailable(dd_run_check, aggregator, instance, mock_http_get):
+    check = ProxmoxCheck('proxmox', {}, [instance])
+    dd_run_check(check)
+
+    aggregator.assert_metric(
+        "proxmox.api.up", 1, tags=['proxmox_server:http://localhost:8006/api2/json', 'proxmox_status:up', 'testing']
+    )
+    aggregator.assert_metric("proxmox.node.up", 1, tags=[], hostname='ip-122-82-3-112')
+    aggregator.assert_metric("proxmox.vm.up", 1, tags=[], hostname="debian")
+    aggregator.assert_metric("proxmox.ha.quorum", hostname='ip-122-82-3-112', tags=['node_status:OK'])
+
+
 @pytest.mark.usefixtures('mock_http_get')
 def test_perf_metrics_error(dd_run_check, caplog, instance):
     check = ProxmoxCheck('proxmox', {}, [instance])