Skip to content

Commit bead066

Browse files
vitkyrkaclaude
andauthored
Add metrics_prefix to discovery block (DataDog#24861)
* Manually author discovery metrics_prefix in spec.yaml for gearmand, krakend, prefect Alternative to PR DataDog#24738's auto-detection approach, which computed each integration's metrics_prefix from manifest.json or the repo's .ddev/config.toml override table at `ddev validate config` time. Integration owners raised a concern that this made .ddev/config.toml, a developer/tooling config file, silently production-critical, since a wrong or missing entry there would flow straight into the auto_conf.yaml shipped with the Agent. This hand-authors the same metrics_prefix values directly in each integration's assets/configuration/spec.yaml via a discovery.example override on the existing auto_conf/discovery template, using the same override mechanism already used for ad_identifiers' value.example and krakend's cel_selector.example. auto_conf.yaml is then regenerated with `ddev validate config -s`, producing output identical to PR DataDog#24738's. Environment: Datadog workspace Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * Add changelog entries for PR DataDog#24861 Environment: Datadog workspace Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
1 parent fa4dc5c commit bead066

9 files changed

Lines changed: 18 additions & 3 deletions

File tree

gearmand/assets/configuration/spec.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,3 +55,6 @@ files:
5555
value.example:
5656
- gearmand
5757
- template: auto_conf/discovery
58+
overrides:
59+
discovery.example:
60+
metrics_prefix: gearman

gearmand/changelog.d/24861.added

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Add ``metrics_prefix`` to the ``discovery`` block of ``auto_conf.yaml``.

gearmand/datadog_checks/gearmand/data/auto_conf.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,8 @@ ad_identifiers:
88

99
## Enables configuration discovery
1010
#
11-
discovery: {}
11+
discovery:
12+
metrics_prefix: gearman
1213

1314
## Unused init configuration
1415
#

krakend/assets/configuration/spec.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -86,3 +86,6 @@ files:
8686
processes:
8787
- "process.name == 'krakend'"
8888
- template: auto_conf/discovery
89+
overrides:
90+
discovery.example:
91+
metrics_prefix: krakend.api

krakend/changelog.d/24861.added

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Add ``metrics_prefix`` to the ``discovery`` block of ``auto_conf.yaml``.

krakend/datadog_checks/krakend/data/auto_conf.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,8 @@ cel_selector:
1414

1515
## Enables configuration discovery
1616
#
17-
discovery: {}
17+
discovery:
18+
metrics_prefix: krakend.api
1819

1920
## Unused init configuration
2021
#

prefect/assets/configuration/spec.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -160,4 +160,7 @@ files:
160160
value.example:
161161
- prefect
162162
- template: auto_conf/discovery
163+
overrides:
164+
discovery.example:
165+
metrics_prefix: prefect.server
163166

prefect/changelog.d/24861.added

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Add ``metrics_prefix`` to the ``discovery`` block of ``auto_conf.yaml``.

prefect/datadog_checks/prefect/data/auto_conf.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,8 @@ ad_identifiers:
88

99
## Enables configuration discovery
1010
#
11-
discovery: {}
11+
discovery:
12+
metrics_prefix: prefect.server
1213

1314
## Unused init configuration
1415
#

0 commit comments

Comments
 (0)