Improve error created when Kind or other dependencies are not install… (DataDog#21402)

* Improve error created when Kind or other dependencies are not installed when running ddev test

* Fix read_text signature for Python 3.12 mypy compatibility

* Fix read_text signature for Python 3.12 mypy compatibility & Improve error created when Kind or other dependencies are not install

* Modifying error message formating

* Fix message formatting to a single line

* Fix read_text signature to match Python’s definition - add newline parameter

* Revert read_text default encoding to UTF-8

Author: ddog-nasirthomas

ddev/changelog.d/21402.added

@@ -0,0 +1 @@
+Improve error message when Kind or other dependencies are missing; fix read_text signature for Python 3.12 mypy compatibility

ddev/src/ddev/cli/env/start.py

@@ -126,7 +126,8 @@ def start(
                 app.abort(code=process.returncode)
 
         if not result_file.is_file():  # no cov
-            app.abort(f'No E2E result file found: {result_file}')
+            errors = process.stderr
+            app.abort(f'No E2E result file found: {result_file}, Errors: {errors}')
 
         result = json.loads(result_file.read_text())
 

ddev/src/ddev/utils/fs.py

@@ -44,7 +44,7 @@ def resolve(self, strict=False) -> Path:
         # https://bugs.python.org/issue38671
         return Path(os.path.realpath(self))
 
-    def read_text(self, encoding='utf-8', errors=None) -> str:
+    def read_text(self, encoding='utf-8', errors=None, newline=None) -> str:
         return super().read_text(encoding, errors)
 
     def write_text(self, *args, **kwargs) -> int:

ddev/tests/cli/env/test_start.py

@@ -23,24 +23,28 @@ def free_port(mocker):
 class TestValidations:
     def test_no_result_file(self, ddev, helpers, mocker):
         result_file = Path()
+        mock_process = None
 
         def _save_result_file(*args, **kwargs):
-            nonlocal result_file
+            nonlocal result_file, mock_process
             result_file = Path(os.environ[E2EEnvVars.RESULT_FILE])
-            return mocker.MagicMock(returncode=0)
+            mock_process = mocker.MagicMock(returncode=0)
+            mock_process.stderr = "Kind not installed, please install to run the 'test' command"
+            return mock_process
 
         mocker.patch('subprocess.run', side_effect=_save_result_file)
 
         integration = 'postgres'
         environment = 'py3.12'
 
         result = ddev('env', 'start', integration, environment)
+        errors = mock_process.stderr
 
         assert result.exit_code == 1, result.output
         assert result.output == helpers.dedent(
             f"""
             ─────────────────────────────── Starting: py3.12 ───────────────────────────────
-            No E2E result file found: {result_file}
+            No E2E result file found: {result_file}, Errors: {errors}
             """
         )